-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent infinite loop when updating a table row in place #7154
Prevent infinite loop when updating a table row in place #7154
Conversation
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/23/2023 10:51:18am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: a8294a1 Started: 10/23/2023 10:46:33am UTC Current Playwright Test Results Summary✅ 144 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/23/2023 10:51:18am UTC)
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
6.67% (4)4 / 60 runsfailed over last 7 days |
45% (27)27 / 60 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
3.45% (2)2 / 58 runsfailed over last 7 days |
29.31% (17)17 / 58 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
1.12% (1)1 / 89 runfailed over last 7 days |
50.56% (45)45 / 89 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #7154 +/- ##
===========================================
- Coverage 55.62% 41.84% -13.79%
===========================================
Files 651 414 -237
Lines 26186 12920 -13266
Branches 2535 0 -2535
===========================================
- Hits 14566 5406 -9160
+ Misses 10914 7514 -3400
+ Partials 706 0 -706
... and 521 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…es-open-mct-to-freeze
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor! LGTM
Closes akhenry/openmct-yamcs#384
Describe your changes:
When updating a row in place, we need to be sure to bump the
incomingRowIndex
so we don't have an infinite loop.All Submissions:
Author Checklist
Reviewer Checklist