-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#7143): add eslint-plugin-no-sanitize
and fix errors
#7144
Conversation
- also convert from AMD to ES6 class
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/14/2023 12:11:22am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: f59737b Started: 10/14/2023 12:09:04am UTC Current Playwright Test Results Summary✅ 143 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/14/2023 12:11:22am UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Timer Can perform actions on the Timer
Retry 1 • Initial Attempt |
0% (0)0 / 54 runsfailed over last 7 days |
11.11% (6)6 / 54 runsflaked over last 7 days |
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
-1.89% (-1)-1 / 53 runsfailed over last 7 days |
37.74% (20)20 / 53 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
1.85% (1)1 / 54 runfailed over last 7 days |
25.93% (14)14 / 54 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 51 runsfailed over last 7 days |
50.98% (26)26 / 51 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
5.77% (3)3 / 52 runsfailed over last 7 days |
67.31% (35)35 / 52 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #7144 +/- ##
==========================================
+ Coverage 55.23% 55.40% +0.16%
==========================================
Files 651 651
Lines 26170 26187 +17
Branches 2535 2535
==========================================
+ Hits 14456 14508 +52
+ Misses 11013 10987 -26
+ Partials 701 692 -9
*This pull request uses carry forward flags. Click here to find out more.
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have one comment you can address or shoo away.
Closes #7143
Describe your changes:
eslint
rules fromeslint-plugin-no-unsanitized
to catch bad usage of.innerHTML
.innerHTML
out of our codebase.All Submissions:
Author Checklist
Reviewer Checklist