Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cspell): use --quiet flag #7110

Merged
merged 1 commit into from
Oct 4, 2023
Merged

chore(cspell): use --quiet flag #7110

merged 1 commit into from
Oct 4, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Oct 3, 2023

Closes #7109

Describe your changes:

Adds the --quiet flag to our lint:spelling script in order to reduce log bloat from cspell output.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:3.2.0 milestone Oct 3, 2023
@ozyx ozyx requested a review from scottbell October 3, 2023 23:29
@deploysentinel
Copy link

deploysentinel bot commented Oct 3, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/03/2023 11:39:30pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 61f0e0d

Started: 10/03/2023 11:33:41pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
0% (0) 0 / 48 runs
failed over last 7 days
6.25% (3) 3 / 48 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 141 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/03/2023 11:39:30pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 61f0e0d

Started: 10/03/2023 11:32:05pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
0% (0) 0 / 101 runs
failed over last 7 days
32.67% (33) 33 / 101 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
7.37% (7) 7 / 95 runs
failed over last 7 days
49.47% (47) 47 / 95 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 87 runs
failed over last 7 days
43.68% (38) 38 / 87 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery in Display Layout View Large action leaves keeps realtime mode paused
Retry 1Initial Attempt
0% (0) 0 / 103 runs
failed over last 7 days
3.88% (4) 4 / 103 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 134 runs
failed over last 7 days
56.72% (76) 76 / 134 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #7110 (61f0e0d) into master (ce59c0f) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7110      +/-   ##
==========================================
- Coverage   55.60%   55.27%   -0.33%     
==========================================
  Files         650      650              
  Lines       26102    26102              
  Branches     2549     2549              
==========================================
- Hits        14515    14429      -86     
- Misses      10889    10975      +86     
  Partials      698      698              
Flag Coverage Δ *Carryforward flag
e2e-full 41.93% <ø> (ø) Carriedforward from ce59c0f
e2e-stable 57.20% <ø> (+0.01%) ⬆️
unit 48.72% <ø> (-0.51%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce59c0f...61f0e0d. Read the comment docs.

Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottbell scottbell merged commit 5eed5de into master Oct 4, 2023
@scottbell scottbell deleted the mct7109 branch October 4, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress log statements from cspell
2 participants