[Staleness] Fix staleness on clock change #7088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/04/2023 08:06:31pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: d89e1a9 Started: 10/04/2023 08:03:26pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1 • Initial Attempt |
2.13% (1)1 / 47 runfailed over last 7 days |
25.53% (12)12 / 47 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 141 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 10/04/2023 08:06:31pm UTC)
⚠️ Flakes
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
0% (0)0 / 97 runsfailed over last 7 days |
32.99% (32)32 / 97 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
17.71% (17)17 / 96 runsfailed over last 7 days |
54.17% (52)52 / 96 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #7088 +/- ##
==========================================
+ Coverage 55.54% 55.72% +0.18%
==========================================
Files 650 650
Lines 26102 26092 -10
Branches 2549 2519 -30
==========================================
+ Hits 14498 14540 +42
+ Misses 10900 10849 -51
+ Partials 704 703 -1
*This pull request uses carry forward flags. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
khalidadil
changed the title
jvigliotta
reviewed
Oct 2, 2023
jvigliotta
reviewed
Oct 3, 2023
jvigliotta
reviewed
Oct 4, 2023
jvigliotta
approved these changes
Oct 4, 2023
khalidadil
added a commit
that referenced
this pull request
Oct 4, 2023
* Update staleness mixin * Fix listeners and add guard * Add check to make sure staleness only shows for correct clock * Add guard for time api * Cleanup the setting of isStale in ObjectView * Cleanup use of combinedKey on LadTableSet
jvigliotta
pushed a commit
that referenced
this pull request
Oct 4, 2023
[Staleness] Fix staleness on clock change (#7088) * Update staleness mixin * Fix listeners and add guard * Add check to make sure staleness only shows for correct clock * Add guard for time api * Cleanup the setting of isStale in ObjectView * Cleanup use of combinedKey on LadTableSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6339
Describe your changes:
Refactored staleness out of Vue components and into a mixin where possible. Added the function to unsubscribe/resubscribe staleness on clock change, and added a guard to make sure staleness only applied to correct clock.
All Submissions:
Author Checklist
Reviewer Checklist