cherry-pick(#7052): Allow Data Visualization in inspector based on current selection #7062
Conversation
* visualize data in inspector per selection --------- Co-authored-by: Khalid Adil <[email protected]> Co-authored-by: John Hill <[email protected]>
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/15/2023 07:45:06pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 2ff77e2 Started: 09/15/2023 07:39:34pm UTC Current Playwright Test Results Summary✅ 138 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/15/2023 07:45:06pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 5 runsfailed over last 7 days |
20% (1)1 / 5 runflaked over last 7 days |
📄 functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Autoscale User can set autoscale with a valid range @snapshot
Retry 1 • Initial Attempt |
0% (0)0 / 65 runsfailed over last 7 days |
3.08% (2)2 / 65 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## release/3.0.2 #7062 +/- ##
================================================
Coverage ? 55.27%
================================================
Files ? 651
Lines ? 25854
Branches ? 2527
================================================
Hits ? 14290
Misses ? 10873
Partials ? 691
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
ozyx
changed the title
| <select class="c-inspector__data-pivot-range-selector" v-model="selectedDataRangeIndex"> | ||
| <option | ||
| v-for="(dataRange, index) in descendingDataRanges" | ||
| :key="index" |
There was a problem hiding this comment.
key should be something else than index, preferably an id or something with the dataRange object
There was a problem hiding this comment.
Thanks for that feedback @evenstensberg! This was already merged to master with the existing code, and this PR is cherry-picking into a release that we're cutting this week. I'll leave the code as-is for now, but we'll definitely work to get this cleaned up in master. Thank you for your help!
Cherry pick #7052 to address #7041