-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filters] Fix view based filters when string input is enabled #7050
Conversation
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/24/2023 10:16:05pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 751053d Started: 10/24/2023 10:11:03pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 36 runsfailed over last 7 days |
5.56% (2)2 / 36 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 147 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 10/24/2023 10:16:05pm UTC)
⚠️ Flakes
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0.93% (1)1 / 107 runfailed over last 7 days |
50.47% (54)54 / 107 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
7.50% (6)6 / 80 runsfailed over last 7 days |
48.75% (39)39 / 80 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
2.47% (2)2 / 81 runsfailed over last 7 days |
69.14% (56)56 / 81 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #7050 +/- ##
==========================================
- Coverage 55.77% 55.70% -0.08%
==========================================
Files 651 651
Lines 26187 26189 +2
Branches 2535 2536 +1
==========================================
- Hits 14607 14589 -18
- Misses 10881 10894 +13
- Partials 699 706 +7
*This pull request uses carry forward flags. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a question for you plus it looks like one of the e2e is failing?
Closes #7006
Describe your changes:
Modified the logic for filters that do not have the "possibleValues" key in their metadata which allows string input.
All Submissions:
Author Checklist
Reviewer Checklist