cherry-pick(#6990): Fix and re-enable disabled unit test suites #7049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Playwright Test Results Summary✅ 138 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/12/2023 05:53:21pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Autoscale User can set autoscale with a valid range @snapshot
Retry 2 • Retry 1 • Initial Attempt |
2.78% (1)1 / 36 runfailed over last 7 days |
2.78% (1)1 / 36 runflaked over last 7 days |
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
5.13% (2)2 / 39 runsfailed over last 7 days |
30.77% (12)12 / 39 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery in Display Layout Toggle layer visibility by clicking on label
Retry 1 • Initial Attempt |
0% (0)0 / 37 runsfailed over last 7 days |
5.41% (2)2 / 37 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 69 runsfailed over last 7 days |
47.83% (33)33 / 69 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## release/3.0.2 #7049 +/- ##
================================================
Coverage ? 55.64%
================================================
Files ? 644
Lines ? 25719
Branches ? 2512
================================================
Hits ? 14312
Misses ? 10708
Partials ? 699
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
page.getByRole(...).or is not a function |
ah, i see. we're on 1.32.3 and need to be on >=1.33 |
* fix: register event listeners etc in `created()` hook * fix: initialize `stalenessSubscription` before composition load and in `created()` hook * refactor(test): make `openmct` const * refactor: update overlayPlot spec to Vue 3 and fix tests * refactor: fix eslint errors * refactor: move initialization steps to `created()` hook * test: re-enable and fix stackedPlot test suite * fix: `hideTree=true` hides the tree again * fix: add back in check on mount * test: fix Layout tests * fix: BarGraph test * fix: plot inspector tests * fix: reenable grand search tests * fix: inspectorStyles test suite * fix: re-enable most timeline tests * fix: no need to hideTree in appactions * fix: re-enable more tests * test: re-enable more tests * test: re-enable most plot tests * chore: `lint:fix` * test: re-enable timelist suite * fix(#7016): timers count down or up to a target date * test: add regression tests to cover disabled unit tests * refactor: lint:fix * refactor: no need for momentjs here * fix: timerAction missed refactor * fix: ensure timestamp is always UTC string * test: use role selectors * docs: add instructions for clock override in e2e * docs: update * Update readme * lint * spelling fixes --------- Co-authored-by: Scott Bell <[email protected]> Co-authored-by: John Hill <[email protected]>
ozyx
force-pushed
the
cherry-pick-timer-fix-2
branch
from
598306d to
85ba502
Compare
unlikelyzero
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7016
Issue #7019
Note: Merge #7051 first