-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide image controls when tagging, and hide compass HUD by default #7028
Hide image controls when tagging, and hide compass HUD by default #7028
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7028 +/- ##
==========================================
- Coverage 55.60% 55.18% -0.43%
==========================================
Files 649 649
Lines 26054 26060 +6
Branches 2547 2547
==========================================
- Hits 14487 14380 -107
- Misses 10868 10987 +119
+ Partials 699 693 -6
*This pull request uses carry forward flags. Click here to find out more.
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/28/2023 03:58:10am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 03970e0 Started: 09/28/2023 03:55:54am UTC Current Playwright Test Results Summary✅ 140 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/28/2023 03:58:10am UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
8.97% (7)7 / 78 runsfailed over last 7 days |
26.92% (21)21 / 78 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 78 runsfailed over last 7 days |
55.13% (43)43 / 78 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0.90% (1)1 / 111 runfailed over last 7 days |
55.86% (62)62 / 111 runsflaked over last 7 days |
…-controls-when-annotation-gesture-is-active
…-controls-when-annotation-gesture-is-active
…-controls-when-annotation-gesture-is-active
…-controls-when-annotation-gesture-is-active
…-controls-when-annotation-gesture-is-active
…-controls-when-annotation-gesture-is-active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the showCompasHUD
prop that's passed into Compass.vue
…-controls-when-annotation-gesture-is-active
…-controls-when-annotation-gesture-is-active
Closes #6994 #7012
Describe your changes:
showCompassHUD
to imagery plugin.All Submissions:
Author Checklist
Reviewer Checklist