Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check realtime mode in remote clock interceptor #6985

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Check realtime mode in remote clock interceptor #6985

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e339e76
Revert Date.now() purge change
shefalijoshi Aug 21, 2023
4f1418b
Merge branch 'master' into fix-plots-missing-data
ozyx Oct 3, 2023
4dce3aa
docs: clarify comment
ozyx Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/plugins/remoteClock/requestInterceptor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,16 @@ function remoteClockRequestInterceptor(openmct, _remoteClockIdentifier, waitForB
return activeClock?.key === 'remote-clock' && !remoteClockLoaded;
},
invoke: async (request) => {
const { start, end } = await waitForBounds();
remoteClockLoaded = true;
request.start = start;
request.end = end;
const timeContext = request?.timeContext ?? openmct.time;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️


// Wait for initial bounds if the request is for real-time data.
// Otherwise, use the bounds provided by the request.
if (timeContext.isRealTime()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be if (!timeContext.isRealTime()) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. We only want to take the bounds from waitForBounds() if we're in realtime mode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clarify the comment? The way it reads seems confusing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree, I think this is good to go after making this comment more clear.

const { start, end } = await waitForBounds();
remoteClockLoaded = true;
request.start = start;
request.end = end;
}

return request;
}
Expand Down