Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm): dont generate lockfile #6970

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented Aug 20, 2023

Closes #6973

Describe your changes:

I noticed you don't save the lockfile in git, so I added a restriction in npmrc to not generate one.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Aug 20, 2023

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/21/2023 10:49:04pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 3b1adea

Started: 08/21/2023 10:41:50pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
1.78% (3) 3 / 169 runs
failed over last 7 days
35.50% (60) 60 / 169 runs
flaked over last 7 days

📄   functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Plot Tagging Tags work with Overlay Plots
Retry 2Retry 1Initial Attempt
10.18% (17) 17 / 167 runs
failed over last 7 days
30.54% (51) 51 / 167 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 165 runs
failed over last 7 days
40.61% (67) 67 / 165 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 199 runs
failed over last 7 days
53.27% (106) 106 / 199 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #6970 (f51c32e) into master (9ece4e5) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6970      +/-   ##
==========================================
- Coverage   48.29%   48.29%   -0.01%     
==========================================
  Files         643      643              
  Lines       25719    25719              
  Branches     2512     2512              
==========================================
- Hits        12422    12421       -1     
  Misses      12817    12817              
- Partials      480      481       +1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.00% <ø> (ø) Carriedforward from 5bf104b
e2e-stable 57.16% <ø> (ø)
unit 38.70% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ece4e5...f51c32e. Read the comment docs.

@ozyx ozyx added the source:community Community contribution or request label Aug 20, 2023
Copy link
Contributor

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Aug 21, 2023
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 21, 2023
@unlikelyzero unlikelyzero merged commit 351800b into nasa:master Aug 21, 2023
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INFRA]: Add lockignore to .npmrc
4 participants