-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(npm): dont generate lockfile #6970
Conversation
Current Playwright Test Results Summary✅ 136 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/21/2023 10:49:04pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
1.78% (3)3 / 169 runsfailed over last 7 days |
35.50% (60)60 / 169 runsflaked over last 7 days |
📄 functional/plugins/plot/tagging.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Plot Tagging Tags work with Overlay Plots
Retry 2 • Retry 1 • Initial Attempt |
10.18% (17)17 / 167 runsfailed over last 7 days |
30.54% (51)51 / 167 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 165 runsfailed over last 7 days |
40.61% (67)67 / 165 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 199 runsfailed over last 7 days |
53.27% (106)106 / 199 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6970 +/- ##
==========================================
- Coverage 48.29% 48.29% -0.01%
==========================================
Files 643 643
Lines 25719 25719
Branches 2512 2512
==========================================
- Hits 12422 12421 -1
Misses 12817 12817
- Partials 480 481 +1
*This pull request uses carry forward flags. Click here to find out more. see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great
Closes #6973
Describe your changes:
I noticed you don't save the lockfile in git, so I added a restriction in npmrc to not generate one.
All Submissions:
Author Checklist
Reviewer Checklist