Ensure that dynamically created vue components are destroyed. #6948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/17/2023 11:23:43pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 26f67d2 Started: 08/17/2023 11:21:18pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1 • Initial Attempt |
11.29% (7)7 / 62 runsfailed over last 7 days |
27.42% (17)17 / 62 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 136 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 08/17/2023 11:23:43pm UTC)
⚠️ Flakes
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
3.95% (6)6 / 152 runsfailed over last 7 days |
13.82% (21)21 / 152 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 155 runsfailed over last 7 days |
40.65% (63)63 / 155 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 187 runsfailed over last 7 days |
55.61% (104)104 / 187 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6948 +/- ##
==========================================
+ Coverage 48.29% 48.31% +0.02%
==========================================
Files 643 643
Lines 25706 25719 +13
Branches 2509 2512 +3
==========================================
+ Hits 12414 12427 +13
Misses 12812 12812
Partials 480 480
*This pull request uses carry forward flags. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shefalijoshi
added a commit
that referenced
this pull request
Aug 18, 2023
davetsay
pushed a commit
that referenced
this pull request
Aug 21, 2023
…e destroyed (#6958) cherry-pick(6984): Ensure that dynamically created vue components are destroyed. (#6948) Co-authored-by: Jesse Mazzella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes VIPEROMCT-392
Describe your changes:
For dynamically created Vue component instances, make sure the destroy method on the mount utility is called (which in turn triggers the Vue unmount lifecycle hook).
Note: I noticed that there is no API to
removeindicators in the Indicator API. Is this by design? Some indicator components are created dynamically and should be destroyed but there is no hook to destroy them. I guess the hope here is that they will unmount when Open MCT is unloaded.All Submissions:
Author Checklist
Reviewer Checklist