Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): add author #6941

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

evenstensberg
Copy link
Contributor

#6888

Describe your changes:

Adds author field

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added the source:community Community contribution or request label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #6941 (73ade07) into master (f21685e) will decrease coverage by 6.35%.
The diff coverage is n/a.

❗ Current head 73ade07 differs from pull request most recent head e16cbdf. Consider uploading reports for the commit e16cbdf to get more accurate results

@@            Coverage Diff             @@
##           master    #6941      +/-   ##
==========================================
- Coverage   48.39%   42.04%   -6.35%     
==========================================
  Files         643      410     -233     
  Lines       25631    12690   -12941     
  Branches     2496        0    -2496     
==========================================
- Hits        12404     5336    -7068     
+ Misses      12754     7354    -5400     
+ Partials      473        0     -473     
Flag Coverage Δ
e2e-full 42.04% <ø> (+0.01%) ⬆️
e2e-stable ?
unit ?

see 507 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21685e...e16cbdf. Read the comment docs.

@deploysentinel
Copy link

deploysentinel bot commented Aug 15, 2023

Current Playwright Test Results Summary

✅ 134 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/16/2023 09:10:11pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: e16cbdf

Started: 08/16/2023 09:03:57pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 146 runs
failed over last 7 days
46.58% (68) 68 / 146 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 145 runs
failed over last 7 days
44.14% (64) 64 / 145 runs
flaked over last 7 days

View Detailed Build Results


@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 16, 2023
@unlikelyzero unlikelyzero enabled auto-merge (squash) August 16, 2023 21:06
@unlikelyzero unlikelyzero merged commit 2d92223 into nasa:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants