Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the raw series limits so that we can get the raw series limits #6877

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Aug 2, 2023

Closes VIPEROMCT-387

Describe your changes:

Ensure that when setting the series for limits on the map, it is not proxied by Vue3.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@shefalijoshi shefalijoshi requested a review from ozyx August 2, 2023 04:37
@deploysentinel
Copy link

deploysentinel bot commented Aug 2, 2023

Current Playwright Test Results Summary

✅ 131 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/02/2023 04:47:37pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: cb593c9

Started: 08/02/2023 04:41:26pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/02/2023 04:47:37pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: cb593c9

Started: 08/02/2023 04:34:00pm UTC

⚠️ Flakes

📄   functional/couchdb.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
CouchDB Status Indicator with mocked responses @couchdb Shows unknown if it receives an unexpected response code
Retry 1Initial Attempt
0% (0) 0 / 57 runs
failed over last 7 days
5.26% (3) 3 / 57 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #6877 (77abd5e) into master (0421936) will decrease coverage by 1.75%.
The diff coverage is n/a.

❗ Current head 77abd5e differs from pull request most recent head cb593c9. Consider uploading reports for the commit cb593c9 to get more accurate results

@@            Coverage Diff             @@
##           master    #6877      +/-   ##
==========================================
- Coverage   48.26%   46.51%   -1.75%     
==========================================
  Files         643      643              
  Lines       25629    25622       -7     
  Branches     2505     2505              
==========================================
- Hits        12369    11919     -450     
- Misses      12783    13229     +446     
+ Partials      477      474       -3     
Flag Coverage Δ *Carryforward flag
e2e-full 41.99% <ø> (ø) Carriedforward from 751c3f7
e2e-stable 52.05% <ø> (-5.00%) ⬇️
unit 38.77% <ø> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/plugins/plot/chart/MctChart.vue 1.70% <ø> (ø)

... and 72 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0421936...cb593c9. Read the comment docs.

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's toRaw() any other set, get, or delete for seriesLimits and seriesElements while we're at it, just to be safe.

@ozyx ozyx self-requested a review August 2, 2023 16:24
@ozyx ozyx enabled auto-merge (squash) August 2, 2023 16:30
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 2, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 2, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@ozyx ozyx merged commit c630569 into master Aug 2, 2023
@ozyx ozyx deleted the fix-limit-lines-vue3 branch August 2, 2023 16:50
ozyx added a commit that referenced this pull request Aug 2, 2023
…raw series limits

* Set the raw series limits so that we can get the raw series limits

* fix: `toRaw()` the other gets/sets/deletes

---------

Co-authored-by: Jesse Mazzella <[email protected]>
ozyx added a commit that referenced this pull request Aug 2, 2023
…raw series limits (#6883)

* Set the raw series limits so that we can get the raw series limits

* fix: `toRaw()` the other gets/sets/deletes

---------

Co-authored-by: Shefali Joshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants