-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the raw series limits so that we can get the raw series limits #6877
Conversation
Current Playwright Test Results Summary✅ 131 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/02/2023 04:47:37pm UTC) Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/02/2023 04:47:37pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: cb593c9 Started: 08/02/2023 04:34:00pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
CouchDB Status Indicator with mocked responses @couchdb Shows unknown if it receives an unexpected response code
Retry 1 • Initial Attempt |
0% (0)0 / 57 runsfailed over last 7 days |
5.26% (3)3 / 57 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6877 +/- ##
==========================================
- Coverage 48.26% 46.51% -1.75%
==========================================
Files 643 643
Lines 25629 25622 -7
Branches 2505 2505
==========================================
- Hits 12369 11919 -450
- Misses 12783 13229 +446
+ Partials 477 474 -3
*This pull request uses carry forward flags. Click here to find out more.
... and 72 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's toRaw()
any other set, get, or delete for seriesLimits
and seriesElements
while we're at it, just to be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve
…raw series limits * Set the raw series limits so that we can get the raw series limits * fix: `toRaw()` the other gets/sets/deletes --------- Co-authored-by: Jesse Mazzella <[email protected]>
…raw series limits (#6883) * Set the raw series limits so that we can get the raw series limits * fix: `toRaw()` the other gets/sets/deletes --------- Co-authored-by: Shefali Joshi <[email protected]>
Closes VIPEROMCT-387
Describe your changes:
Ensure that when setting the series for limits on the map, it is not proxied by Vue3.
All Submissions:
Author Checklist
Reviewer Checklist