-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow editing line more when not editing display layout #6858
Conversation
Current Playwright Test Results Summary✅ 131 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/31/2023 05:16:36pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 2 • Retry 1 • Initial Attempt |
8.64% (7)7 / 81 runsfailed over last 7 days |
33.33% (27)27 / 81 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
1.47% (1)1 / 68 runfailed over last 7 days |
17.65% (12)12 / 68 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery Object Can use independent time conductor to change time
Retry 1 • Initial Attempt |
17.33% (13)13 / 75 runsfailed over last 7 days |
14.67% (11)11 / 75 runsflaked over last 7 days |
📄 functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Autoscale User can set autoscale with a valid range @snapshot
Retry 2 • Retry 1 • Initial Attempt |
28% (21)21 / 75 runsfailed over last 7 days |
17.33% (13)13 / 75 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 14 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 07/31/2023 05:16:36pm UTC)
Run Details
Running Workflow e2e-couchdb on Github Actions
Commit: 9cbce3c
Started: 07/31/2023 05:03:56pm UTC
⚠️ Flakes
📄 functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1 • Initial Attempt |
6.67% (3)3 / 45 runsfailed over last 7 days |
20% (9)9 / 45 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6858 +/- ##
==========================================
- Coverage 48.29% 48.18% -0.12%
==========================================
Files 643 643
Lines 25619 25619
Branches 2507 2507
==========================================
- Hits 12373 12344 -29
- Misses 12757 12799 +42
+ Partials 489 476 -13
*This pull request uses carry forward flags. Click here to find out more.
... and 30 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and with VIPER testing environment-- works well! Nice fix.
Closes #6846
Describe your changes:
Check if we're in edit mode before showing frame edit for line view
All Submissions:
Author Checklist
Reviewer Checklist