Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch staleness provider for SWG to use modeChanged instead of clock #6845

Merged
merged 58 commits into from
Jul 28, 2023
Merged

Switch staleness provider for SWG to use modeChanged instead of clock #6845

Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
72c432f
clock, timeConductor and appActions fixes
shefalijoshi Jul 19, 2023
f9c5e12
Ensure realtime uses upstream context when available
shefalijoshi Jul 19, 2023
34229d3
Remove log statement
shefalijoshi Jul 19, 2023
6769fb4
Fix log plot e2e tests
shefalijoshi Jul 19, 2023
9b4410d
Fix displayLayout e2e tests
shefalijoshi Jul 19, 2023
c400c7c
Specify global time conductor to fix issues with duplicate selectors …
khalidadil Jul 19, 2023
2d16e91
a11y: ARIA for conductor and independent time conductor
ozyx Jul 19, 2023
3dab216
a11y: more accessibility for TC
ozyx Jul 20, 2023
c6ff7f2
a11y: fix label collisions, specify 'Menu' in label
ozyx Jul 20, 2023
6d68512
Add watch mode
unlikelyzero Jul 20, 2023
e94cf27
fix(e2e): update appActions and tests to use a11y locators for ITC
ozyx Jul 20, 2023
f48afeb
add fixmes to e2e tests failing due to regressions
davetsay Jul 20, 2023
7db9805
Don't remove the itc popup from the DOM. Just show/hide it once it's …
shefalijoshi Jul 20, 2023
99cb909
test(e2e): disable one imagery test due to known bug
ozyx Jul 20, 2023
dc0f461
test(e2e): fix ITC imagery test
ozyx Jul 20, 2023
43fa104
Add fixme to tagging tests, issue described in 6822
khalidadil Jul 20, 2023
625bdc0
Fix locator for time conductor popups
shefalijoshi Jul 20, 2023
8d5219c
Improve how time bounds are set in independent time conductor.
shefalijoshi Jul 21, 2023
771158d
Fix some tests for itc for display layouts
shefalijoshi Jul 21, 2023
cb93d17
Fix Inspector tabs remounting on change
shefalijoshi Jul 21, 2023
05a1d53
fix autoscale test and snapshot
shefalijoshi Jul 21, 2023
c77bbc1
Fix telemetry table test
shefalijoshi Jul 21, 2023
a1d9842
Fix timestrip test
shefalijoshi Jul 21, 2023
2719a28
e2e: move test info annotations to within test
ozyx Jul 21, 2023
bdf8601
6826: Fixes padStart error due to using it on a number rather than a …
shefalijoshi Jul 21, 2023
9f77c03
fix(e2e): update snapshots
ozyx Jul 21, 2023
9a946bc
fix(e2e): fix restricted notebook locator
ozyx Jul 21, 2023
e0fc2ae
fix(restrictedNotebook): fix issue causing sections not to update on …
ozyx Jul 21, 2023
c1d1b03
Merge branch 'e2e-test-fixes' of https://github.com/nasa/openmct into…
shefalijoshi Jul 21, 2023
76c37ff
fix(restrictedNotebook): fix issue causing snapshots to not be able t…
ozyx Jul 21, 2023
b41c98d
fix: replace all instances of `$delete` with `Array.splice()` or `del…
ozyx Jul 21, 2023
724ec42
fix(e2e): fix grand search test
ozyx Jul 21, 2023
23a0ddb
fix(#3117): can remove item from displayLayout via tree context menu …
ozyx Jul 24, 2023
eeff0a7
fix: remove typo
ozyx Jul 24, 2023
fdae0ce
Wait for background image to load
khalidadil Jul 24, 2023
e92b8f9
fix(#6832): timelist events can tick down
ozyx Jul 24, 2023
df93905
fix: ensure that menuitems have the raw objects so emits work
ozyx Jul 24, 2023
4daf88c
fix: assign new arrays instead of editing state in-place
ozyx Jul 24, 2023
d888553
refactor(timelist): use `getClock()` instead of `clock()`
ozyx Jul 24, 2023
4243b88
refactor: `lint:fix`
ozyx Jul 24, 2023
ba2662a
Revert "refactor(timelist): use `getClock()` instead of `clock()`"
ozyx Jul 25, 2023
e305a9b
refactor(timelist): use new timeAPI
ozyx Jul 25, 2023
f451593
Stop ticking when the independent time context is disabled (#6833)
shefalijoshi Jul 25, 2023
e63a941
test: update couchdb notebook test
ozyx Jul 25, 2023
e9b2d71
fix: codeQL warnings
ozyx Jul 25, 2023
ee3a1cc
fix(tree-item): infinite spinner issue
ozyx Jul 26, 2023
3b6f5c9
[Timer] Remove "refresh" call, it is not needed (#6841)
jvigliotta Jul 26, 2023
6629454
fix(mct-tree): maintain reactivity of all tree items
ozyx Jul 26, 2023
fffc218
Hide change role button in the indicator in cases where there is only…
khalidadil Jul 26, 2023
222da49
Fix ITC issues and one imagery issue
shefalijoshi Jul 26, 2023
f846e6c
Closes #6829
charlesh88 Jul 26, 2023
19ff98b
Fix menuAPI unit tests
shefalijoshi Jul 26, 2023
b670999
Merge branch 'e2e-test-fixes' of https://github.com/nasa/openmct into…
shefalijoshi Jul 26, 2023
c1ed7b4
fix(DisplayLayout): Edit Marquee updates correctly on multiselect
ozyx Jul 26, 2023
6aa7597
Fix ObjectAPI tests
shefalijoshi Jul 26, 2023
a66967e
Merge branch 'e2e-test-fixes' of https://github.com/nasa/openmct into…
shefalijoshi Jul 26, 2023
975ea47
Switch staleness provider for SWG to use modeChanged instead of clock
khalidadil Jul 27, 2023
9e582bd
Merge branch 'master' of https://github.com/nasa/openmct into bugfix/…
shefalijoshi Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions example/generator/SinewaveStalenessProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default class SinewaveLimitProvider extends EventEmitter {
const id = this.#getObjectKeyString(domainObject);

if (this.#isRealTime === undefined) {
this.#updateRealTime(this.#openmct.time.clock());
this.#updateRealTime(this.#openmct.time.getMode());
}

this.#handleClockUpdate();
Expand Down Expand Up @@ -92,15 +92,15 @@ export default class SinewaveLimitProvider extends EventEmitter {

if (observers && !this.#watchingTheClock) {
this.#watchingTheClock = true;
this.#openmct.time.on('clock', this.#updateRealTime, this);
this.#openmct.time.on('modeChanged', this.#updateRealTime, this);
} else if (!observers && this.#watchingTheClock) {
this.#watchingTheClock = false;
this.#openmct.time.off('clock', this.#updateRealTime, this);
this.#openmct.time.off('modeChanged', this.#updateRealTime, this);
}
}

#updateRealTime(clock) {
this.#isRealTime = clock !== undefined;
#updateRealTime(mode) {
this.#isRealTime = mode !== 'fixed';

if (!this.#isRealTime) {
Object.keys(this.#observingStaleness).forEach((id) => {
Expand Down