Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Update package engine version range to block on node 20 #6736

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

unlikelyzero
Copy link
Contributor

@unlikelyzero unlikelyzero commented Jun 16, 2023

Buffer in place until we can formally support #6732

Describe your changes:

[node_modules/@achrinza/node-ipc](https://github.com/achrinza/node-ipc/issues/45) has a version range up to 20 and is failing builds for folks using 20. We should be more explicit in our deps and tackle node20 holistically.

Until then, we should be preventing installs on node20.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Jun 16, 2023

Current Playwright Test Results Summary

✅ 119 Passing - ❌ 1 Failing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/16/2023 02:53:06pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 075e87e

Started: 06/16/2023 02:48:00pm UTC

❌ Failures

📄   framework/baseFixtures.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
baseFixtures tests Verify that tests fail if console.error is thrown
Initial Attempt
Error: Console error detected: [error] This should result in a failure at ( 0:14)...
Console error detected: [error] This should result in a failure at ( 0:14)

Expected: not "error"

100% (92) 92 / 92 runs
failed over last 7 days
0% (0) 0 / 92 runs
flaked over last 7 days

⚠️ Flakes

📄   functional/plugins/timeConductor/timeConductor.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time conductor input fields real-time mode preserve offsets and url params when switching between fixed and real-time mode
Retry 2Retry 1Initial Attempt
0% (0) 0 / 54 runs
failed over last 7 days
5.56% (3) 3 / 54 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #6736 (075e87e) into master (fb5bbde) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6736   +/-   ##
=======================================
  Coverage   54.10%   54.10%           
=======================================
  Files         623      623           
  Lines       24634    24634           
  Branches     2464     2464           
=======================================
  Hits        13328    13328           
+ Misses      10648    10644    -4     
- Partials      658      662    +4     
Flag Coverage Δ *Carryforward flag
e2e-full 42.20% <ø> (ø) Carriedforward from fb5bbde
e2e-stable 55.21% <ø> (+0.04%) ⬆️
unit 48.81% <ø> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb5bbde...075e87e. Read the comment docs.

Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unlikelyzero unlikelyzero merged commit 4c5de37 into master Jun 16, 2023
@unlikelyzero unlikelyzero deleted the block-node20 branch June 16, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants