-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unlisten to annotation event beforeDestroy #6690
Conversation
Current Playwright Test Results Summary✅ 12 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/24/2023 09:29:06am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 0097a85 Started: 05/24/2023 09:26:13am UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt |
0% (0)0 / 22 runsfailed over last 7 days |
36.36% (8)8 / 22 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6690 +/- ##
==========================================
- Coverage 54.06% 54.05% -0.02%
==========================================
Files 623 623
Lines 24565 24566 +1
Branches 2456 2456
==========================================
- Hits 13282 13278 -4
- Misses 10626 10628 +2
- Partials 657 660 +3
*This pull request uses carry forward flags. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix @ozyx
Closes #6689
Describe your changes:
Stops listeners from stacking up when clicking through to view multiple annotations.
TODO: CouchDB / YAMCS quickstart regression test
All Submissions:
Author Checklist
Reviewer Checklist