Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Locator in Move and Link dialogs #6663

Merged
merged 1 commit into from
May 16, 2023
Merged

Fix Locator in Move and Link dialogs #6663

merged 1 commit into from
May 16, 2023

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented May 12, 2023

Closes #6654

  • Corrected form builder configurations.

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

- Corrected form builder configurations.
@charlesh88 charlesh88 requested review from ozyx and jvigliotta May 12, 2023 16:30
@charlesh88 charlesh88 added the bug:regression It used to work. Now it doesn't :( label May 12, 2023
@ozyx ozyx added this to the Target:2.2.4 milestone May 12, 2023
@deploysentinel
Copy link

deploysentinel bot commented May 12, 2023

Current Playwright Test Results Summary

✅ 119 Passing - ❌ 1 Failing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/12/2023 04:37:30pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: ac5c64c

Started: 05/12/2023 04:32:39pm UTC

❌ Failures

📄   framework/baseFixtures.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
baseFixtures tests Verify that tests fail if console.error is thrown
Initial Attempt
Error: Console error detected: [error] This should result in a failure at ( 0:14)...
Console error detected: [error] This should result in a failure at ( 0:14)

Expected: not "error"

100% (95) 95 / 95 runs
failed over last 7 days
0% (0) 0 / 95 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Once this PR lands, we should add a visual test for the link and move dialogs so we can catch regressions like this in the future.

@ozyx ozyx merged commit 225fa22 into master May 16, 2023
@ozyx ozyx deleted the fix-locator-6654 branch May 16, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move and Link dialog's Locator is way too small
2 participants