[LAD Table][Browse Bar] Visual test and title attributes for actions #6640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for column sizing in lad tables
Current Playwright Test Results Summary✅ 118 Passing - ❌ 1 Failing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/04/2023 12:52:58am UTC) ❌ Failures📄 framework/baseFixtures.e2e.spec.js • 1 FailureTest Case Results
|
ozyx
suggested changes
May 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #6640 +/- ##
==========================================
+ Coverage 54.17% 54.18% +0.01%
==========================================
Files 623 623
Lines 24373 24374 +1
Branches 2412 2412
==========================================
+ Hits 13204 13208 +4
+ Misses 10511 10506 -5
- Partials 658 660 +2
*This pull request uses carry forward flags. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ozyx
suggested changes
May 3, 2023
| }); | ||
| test('Toggled column widths behave accordingly', async ({ page, theme }) => { | ||
|
|
||
| await page.goto(ladTable.url, { waitUntil: 'domcontentloaded' }); |
There was a problem hiding this comment.
We can remove the waitUntil here, since it isn't the initial page navigation
unlikelyzero
approved these changes
May 3, 2023
ozyx
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6639
Describe your changes:
Added title attributes to actions in the browse bar that will pull from the action names, like we do elsewhere in the code. Added a visual test for LAD Table column sizing fix in: #6636
All Submissions:
Author Checklist
Reviewer Checklist