Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking a plot annotation should pause the plot #6446

Merged

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Mar 16, 2023

Closes #6443 #6214 #6458

Describe your changes:

Pause plot when clicking on plot annotation search result. Get rid of rectangles when resuming realtime data.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@scottbell scottbell linked an issue Mar 16, 2023 that may be closed by this pull request
7 tasks
@scottbell scottbell self-assigned this Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #6446 (37e7d8a) into master (8fe0472) will increase coverage by 2.37%.
The diff coverage is 15.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6446      +/-   ##
==========================================
+ Coverage   52.46%   54.84%   +2.37%     
==========================================
  Files         626      626              
  Lines       26615    26630      +15     
  Branches     2403     2405       +2     
==========================================
+ Hits        13964    14605     +641     
+ Misses      11987    11361     -626     
  Partials      664      664              
Flag Coverage Δ *Carryforward flag
e2e-ci 39.35% <ø> (ø) Carriedforward from b1198a3
e2e-full 51.08% <ø> (ø) Carriedforward from b1198a3
e2e-stable 55.41% <ø> (?)
unit 49.19% <15.00%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/ui/layout/search/AnnotationSearchResult.vue 0.00% <0.00%> (ø)
src/plugins/plot/MctPlot.vue 37.46% <23.07%> (-0.15%) ⬇️

... and 84 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe0472...37e7d8a. Read the comment docs.

@scottbell scottbell requested a review from shefalijoshi March 17, 2023 12:14
@akhenry akhenry added the sim-3 label Mar 17, 2023
@scottbell scottbell requested a review from khalidadil March 17, 2023 16:23
@shefalijoshi
Copy link
Contributor

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants