do not show loaded tabs before showing current tab #6424
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6424 +/- ##
==========================================
- Coverage 54.78% 54.67% -0.11%
==========================================
Files 620 620
Lines 26518 26523 +5
Branches 2399 2400 +1
==========================================
- Hits 14528 14502 -26
- Misses 11341 11370 +29
- Partials 649 651 +2
*This pull request uses carry forward flags. Click here to find out more.
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
e2e test to be covered in #6425 |
src/plugins/tabs/components/tabs.vue
Outdated
| @@ -123,6 +123,7 @@ export default { | |||
| this.composition.on('remove', this.removeItem); | |||
| this.composition.on('reorder', this.onReorder); | |||
| this.composition.load().then(() => { | |||
| this.setCurrentTab = true; | |||
There was a problem hiding this comment.
This will also catch the case where the composition is empty and someone adds stuff to it after the view is mounted right?
OR if there is an error loading the composition?
There was a problem hiding this comment.
good catch. i need to conditionally set this.setCurrentTab = true if composition is empty.
There was a problem hiding this comment.
One small issue.
TabsViewNotVisible.mov
In fixed timespan mode:
Add a few objects to the tabs view
Make sure that generally the right tab shows up as you navigate away and back.
Using the navigation tree, remove all objects from the tabs view composition and then navigate away to another object and come back to the empty tabs view.
Add an object to the view (or 2 objects). Newly added objects are not visible.
Manually selecting a tab does resolve this.
|
@shefalijoshi . nice catch. pushed fix. i'll search to see if we have an issue filed for that. |
Closes #6387
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist