Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#6317): [Notebook] Fix link formatting on load, remove duplicate snapshot indicator #6324

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Feb 10, 2023

Issues #6202 #6316

  • adding urlWhitelist to data so when/if it is updated it triggers link formatting

  • removing dupe notebook and restricted notebook checks and just moving it to base notebook functionality install checks

…plicate snapshot indicator

* adding urlWhitelist to data so when/if it is updated it triggers link formatting

* removing dupe notebook and restricted notebook checks and just moving it to base notebook functionality install checks

* nullthing to see here
@ozyx ozyx added this to the Target:2.1.6 milestone Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/2.1.6@242fa3c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             release/2.1.6    #6324   +/-   ##
================================================
  Coverage                 ?   54.66%           
================================================
  Files                    ?      607           
  Lines                    ?    26128           
  Branches                 ?     2392           
================================================
  Hits                     ?    14282           
  Misses                   ?    11181           
  Partials                 ?      665           
Flag Coverage Δ *Carryforward flag
e2e-ci 39.38% <0.00%> (?) Carriedforward from 8847c86
e2e-full 51.12% <0.00%> (?) Carriedforward from 8847c86
e2e-stable 54.11% <0.00%> (?)
unit 49.28% <0.00%> (?)

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 242fa3c...895908f. Read the comment docs.

@akhenry akhenry enabled auto-merge (squash) February 10, 2023 23:09
@akhenry akhenry self-requested a review February 10, 2023 23:09
@akhenry akhenry merged commit 31ff6f2 into release/2.1.6 Feb 10, 2023
@akhenry akhenry deleted the cherry-pick-6317 branch February 10, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants