-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspector tabs #6137
Inspector tabs #6137
Conversation
fix unit test
fix unit test
fix unit test
Codecov Report
@@ Coverage Diff @@
## master #6137 +/- ##
==========================================
- Coverage 55.03% 54.82% -0.21%
==========================================
Files 607 617 +10
Lines 26245 26346 +101
Branches 2395 2381 -14
==========================================
+ Hits 14444 14445 +1
- Misses 11137 11256 +119
+ Partials 664 645 -19
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor comments. This is looking really awesome.
this should be good to go again. I just need to confirm with you that merge conflict resolution didn't bork annotations, @scottbell. |
@scottbell , when you get a chance. I'll need some help in knowing if I borked annotations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested tags against notebooks, stacked plots, overlay plots, and search - looks good, Dave!
…t into inspector-tabs-w-git-history
Closes #6118
Describe your changes:
selection
andisEditing
(only for now)All Submissions:
Author Checklist
Reviewer Checklist