Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector tabs #6137

Merged
merged 79 commits into from
Mar 6, 2023
Merged

Inspector tabs #6137

merged 79 commits into from
Mar 6, 2023

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented Jan 18, 2023

Closes #6118

Describe your changes:

  • register all hardcoded inspector views with inspectorViewRegistry
  • views get their own tabs
  • tabs have logic to hide/show based on selection and isEditing (only for now)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@davetsay davetsay added this to the Target:2.1.6 milestone Jan 18, 2023
@davetsay davetsay requested review from charlesh88 and ozyx January 18, 2023 20:25
@davetsay davetsay self-assigned this Jan 18, 2023
@davetsay davetsay mentioned this pull request Jan 18, 2023
15 tasks
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #6137 (c2e5cfa) into master (8040b27) will decrease coverage by 0.21%.
The diff coverage is 80.37%.

❗ Current head c2e5cfa differs from pull request most recent head c956c78. Consider uploading reports for the commit c956c78 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6137      +/-   ##
==========================================
- Coverage   55.03%   54.82%   -0.21%     
==========================================
  Files         607      617      +10     
  Lines       26245    26346     +101     
  Branches     2395     2381      -14     
==========================================
+ Hits        14444    14445       +1     
- Misses      11137    11256     +119     
+ Partials      664      645      -19     
Flag Coverage Δ *Carryforward flag
e2e-ci 39.40% <ø> (-0.06%) ⬇️ Carriedforward from 2986b45
e2e-full 51.15% <ø> (-0.03%) ⬇️ Carriedforward from 2986b45
e2e-stable 53.87% <79.78%> (-0.48%) ⬇️
unit 49.36% <69.62%> (-0.25%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...rts/bar/inspector/BarGraphInspectorViewProvider.js 90.90% <0.00%> (ø)
...tter/inspector/ScatterPlotInspectorViewProvider.js 54.54% <0.00%> (-36.37%) ⬇️
...gins/condition/components/inspector/StylesView.vue 47.66% <ø> (-3.22%) ⬇️
...ns/displayLayout/AlphanumericFormatViewProvider.js 80.00% <ø> (ø)
...ns/displayLayout/components/AlphanumericFormat.vue 0.00% <ø> (ø)
...ugins/faultManagement/FaultManagementInspector.vue 0.00% <ø> (ø)
...Management/FaultManagementInspectorViewProvider.js 81.81% <0.00%> (ø)
...ctorViews/annotations/AnnotationsInspectorView.vue 0.00% <ø> (ø)
...gins/inspectorViews/annotations/tags/TagEditor.vue 0.00% <ø> (ø)
...s/inspectorViews/annotations/tags/TagSelection.vue 0.00% <ø> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f388d9a...c956c78. Read the comment docs.

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor comments. This is looking really awesome.

@davetsay
Copy link
Contributor Author

this should be good to go again. I just need to confirm with you that merge conflict resolution didn't bork annotations, @scottbell.

@davetsay
Copy link
Contributor Author

@scottbell , when you get a chance. I'll need some help in knowing if I borked annotations

Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested tags against notebooks, stacked plots, overlay plots, and search - looks good, Dave!

@davetsay davetsay marked this pull request as ready for review March 2, 2023 20:29
@ozyx ozyx enabled auto-merge (squash) March 6, 2023 22:02
@ozyx ozyx merged commit 1d4cf1f into master Mar 6, 2023
@ozyx ozyx deleted the inspector-tabs-w-git-history branch March 6, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inspector views tabs
6 participants