Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support thumbnails in ImageryView and ImageryTimeView #6132

Merged
merged 12 commits into from
Jan 21, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Jan 18, 2023

Closes #5931

Describe your changes:

Prefer to use image thumbnail urls if provided via metadata in imageHistory and the imagery timestrip view.

The other half of this PR is implementing thumbnail support on the openmct-yamcs side (providing thumbnail URLs in metadata).

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:2.1.6 milestone Jan 18, 2023
@ozyx ozyx requested a review from akhenry January 18, 2023 00:00
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #6132 (8e9f582) into master (986c596) will increase coverage by 0.11%.
The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6132      +/-   ##
==========================================
+ Coverage   54.73%   54.84%   +0.11%     
==========================================
  Files         602      602              
  Lines       24648    24728      +80     
  Branches     2220     2223       +3     
==========================================
+ Hits        13490    13563      +73     
- Misses      10544    10550       +6     
- Partials      614      615       +1     
Flag Coverage Δ *Carryforward flag
e2e-ci 39.49% <0.00%> (ø) Carriedforward from 986c596
e2e-full 51.23% <93.75%> (ø) Carriedforward from 986c596
e2e-stable 53.11% <94.73%> (+0.04%) ⬆️
unit 49.39% <66.66%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/imagery/components/ImageThumbnail.vue 12.12% <ø> (ø)
src/plugins/imagery/components/ImageryView.vue 44.18% <54.54%> (+0.02%) ⬆️
src/plugins/imagery/components/ImageryTimeView.vue 77.27% <70.00%> (-0.89%) ⬇️
example/imagery/plugin.js 90.24% <83.33%> (+2.97%) ⬆️
src/plugins/imagery/mixins/imageryData.js 92.36% <100.00%> (+2.12%) ⬆️
src/plugins/charts/bar/BarGraphView.vue 54.49% <0.00%> (-3.00%) ⬇️
src/plugins/timeConductor/ConductorHistory.vue 52.47% <0.00%> (+0.99%) ⬆️
.../plugins/timeConductor/ConductorInputsRealtime.vue 51.19% <0.00%> (+1.19%) ⬆️
src/plugins/tabs/components/tabs.vue 36.00% <0.00%> (+1.60%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 986c596...8e9f582. Read the comment docs.

Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! No notes. Just needs a test.

Thanks!

@ozyx ozyx requested a review from akhenry January 20, 2023 18:54
@ozyx ozyx mentioned this pull request Jan 20, 2023
@ozyx
Copy link
Contributor Author

ozyx commented Jan 21, 2023

@akhenry Added thumbnail support to Example Imagery and updated/added unit and e2e tests

@ozyx ozyx merged commit 5e530aa into master Jan 21, 2023
@ozyx ozyx deleted the mct5931-support-imagery-scale-requests branch January 21, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support requesting thumbnail-size images from the Imagery view
2 participants