-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support thumbnails in ImageryView and ImageryTimeView #6132
Conversation
- Prefer an image's thumbnail URL if its available
Codecov Report
@@ Coverage Diff @@
## master #6132 +/- ##
==========================================
+ Coverage 54.73% 54.84% +0.11%
==========================================
Files 602 602
Lines 24648 24728 +80
Branches 2220 2223 +3
==========================================
+ Hits 13490 13563 +73
- Misses 10544 10550 +6
- Partials 614 615 +1
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! No notes. Just needs a test.
Thanks!
- Update imagery view tests to check for use of thumbnail urls
@akhenry Added thumbnail support to Example Imagery and updated/added unit and e2e tests |
Closes #5931
Describe your changes:
Prefer to use image thumbnail urls if provided via metadata in imageHistory and the imagery timestrip view.
The other half of this PR is implementing thumbnail support on the
openmct-yamcs
side (providing thumbnail URLs in metadata).All Submissions:
Author Checklist
Reviewer Checklist