[CLA Approved] test: add e2e test for tracking time conductor history in fixed mode

[sabrinapowell]

Closes #5905

Describe your changes:

E2E tests were added for tracking time conductor history in fixed mode. The test updates the start and end times and checks that the time conductor history is also updated.

NB: I am seeing a bug with the feature being tested. When the end time is updated, the history does not always update. The error happens more than half of the times I have tested it.

Testing

To test the changes, run npm run test:e2e:local -- timeConductor.

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

• Changes address original issue?
• Tests included and/or updated with changes?
• Command line build passes?
• Has this been smoke tested?
• Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

• Changes appear to address issue?
• Reviewer has tested changes by following the provided instructions?
• Changes appear not to be breaking changes?
• Appropriate automated tests included?
• Code style and in-line documentation are appropriate?
• Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
• Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

[codecov]

Codecov Report

Merging #5906 (1703f9b) into master (41fc502) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5906      +/-   ##
==========================================
- Coverage   54.51%   54.49%   -0.02%     
==========================================
  Files         599      599              
  Lines       23331    23331              
  Branches     2080     2080              
==========================================
- Hits        12718    12714       -4     
- Misses      10028    10032       +4     
  Partials      585      585              

Flag	Coverage Δ		*Carryforward flag
e2e-ci	39.49% <ø> (ø)		Carriedforward from 41fc502
e2e-full	51.23% <ø> (ø)		Carriedforward from 41fc502
e2e-stable	46.60% <ø> (-1.96%)	⬇️
unit	50.28% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
src/plugins/plot/configuration/SeriesCollection.js	61.53% <0.00%> (-6.16%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41fc502...1703f9b. Read the comment docs.

[unlikelyzero]

@sabrinapowell Thank you for this submission. It looks great! I'm going to do a more thorough review this afternoon.

It looks like it's failing in CI. Do you know why that might be? Is it related to the bug you mentioned?

[sabrinapowell]

@sabrinapowell Thank you for this submission. It looks great! I'm going to do a more thorough review this afternoon.

It looks like it's failing in CI. Do you know why that might be? Is it related to the bug you mentioned?

Right, the bug is causing the test to fail.

[sabrinapowell]

Hi @unlikelyzero, please let me know when you get a chance to check out the bug. In the meantime, I am available to take another task.

[unlikelyzero]

Hi @unlikelyzero, please let me know when you get a chance to check out the bug. In the meantime, I am available to take another task.

@sabrinapowell sorry! I'm having git issues due to xcode shenangans and just got this checked out! Let me take a look and get back to you.

It sounds like a legit bug and in that case, we'd want to file and issue and use the .annotation() api to link to.

[unlikelyzero]

@sabrinapowell There is a timing issue when running at full speed. I've added some logic to the test to wait for menus to collapse. Will push to your branch

[sabrinapowell]

@unlikelyzero Thanks for looking into it. I'll check out the change once it has been pushed. I also want to write tests for the remaining tests in the file.

[unlikelyzero]

@sabrinapowell unfortunately, we're going to have to close this PR as we're doing a total rewrite of our time conductor plugin. This is, in part, due to the number of bugs you uncovered when writing these tests! When the rewrite is available, I'll ping you in the discussion :)

If you'd like to move onto another area to tackle, please ping me back in the #4303