Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix couchdb no response part deux #5894

Closed
wants to merge 1 commit into from
Closed

Conversation

davetsay
Copy link
Contributor

Closes #5441

Describe your changes:

Adds back deleted code originally fixed in #5474

Handle no response on bulk get requests to couchdb:

  • set couchdb status to disconnected
  • skip applying interceptors.

Also, only set the created date on document creation.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@davetsay davetsay requested a review from shefalijoshi October 19, 2022 20:28
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #5894 (4f29ada) into master (2fa36b2) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5894      +/-   ##
==========================================
- Coverage   54.33%   54.29%   -0.05%     
==========================================
  Files         598      598              
  Lines       22956    23005      +49     
  Branches     2078     2078              
==========================================
+ Hits        12474    12490      +16     
- Misses       9906     9939      +33     
  Partials      576      576              
Flag Coverage Δ *Carryforward flag
e2e-ci 39.49% <100.00%> (ø) Carriedforward from 2fa36b2
e2e-full 51.23% <100.00%> (ø) Carriedforward from 2fa36b2
e2e-stable 36.39% <0.00%> (-12.35%) ⬇️
unit 50.73% <100.00%> (ø) Carriedforward from 2fa36b2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/api/objects/ObjectAPI.js 90.07% <75.00%> (-1.54%) ⬇️
src/plugins/displayLayout/plugin.js 79.59% <0.00%> (-12.25%) ⬇️
src/plugins/plot/configuration/SeriesCollection.js 61.53% <0.00%> (-6.16%) ⬇️
src/plugins/plot/configuration/PlotSeries.js 76.10% <0.00%> (-3.31%) ⬇️
src/api/objects/InMemorySearchProvider.js 71.36% <0.00%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fa36b2...4f29ada. Read the comment docs.

@unlikelyzero unlikelyzero added this to the Target:2.1.2 milestone Oct 19, 2022
@scottbell
Copy link
Contributor

@davetsay just a note that it looks like it was removed in this PR:
https://github.com/nasa/openmct/pull/5654/files

@davetsay
Copy link
Contributor Author

Please disregard @shefalijoshi . You had come up with a new implementation in #5654 so this was indeed removed on purpose.

@davetsay davetsay closed this Oct 21, 2022
@davetsay davetsay deleted the fix-apply-interceptor branch October 21, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared Items disappeared
3 participants