-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Cop 2.0 #5815
Merged
Merged
PR Cop 2.0 #5815
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,17 +6,21 @@ Closes <!--- Insert Issue Number(s) this PR addresses. Start by typing # will op | |
|
||
### All Submissions: | ||
|
||
* [ ] Have you followed the guidelines in our [Contributing document](https://github.com/nasa/openmct/blob/master/CONTRIBUTING.md)? | ||
* [ ] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/nasa/openmct/pulls) for the same update/change? | ||
* [ ] Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots. | ||
|
||
### Contribution Checklist | ||
|
||
* [ ] Have you followed the guidelines in our [Contributing document](https://github.com/nasa/openmct/blob/master/CONTRIBUTING.md)? | ||
* [ ] Have you associated this PR with a `type:` label? | ||
unlikelyzero marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* [ ] Have you associated a milestone with this PR? | ||
unlikelyzero marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* [ ] Testing instructions included in associated issue OR is this a dependency/testcase change? | ||
unlikelyzero marked this conversation as resolved.
Show resolved
Hide resolved
|
||
### Author Checklist | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we just get a space before this to be consistent with the other headers? |
||
|
||
* [ ] Changes address original issue? | ||
* [ ] Tests included and/or updated with changes? | ||
* [ ] Command line build passes? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no longer necessary with our ci |
||
* [ ] Has this been smoke tested? | ||
* [ ] Testing instructions included in associated issue OR is this a dependency/testcase change? | ||
|
||
### Reviewer Checklist | ||
|
||
|
@@ -25,5 +29,3 @@ Closes <!--- Insert Issue Number(s) this PR addresses. Start by typing # will op | |
* [ ] Changes appear not to be breaking changes? | ||
* [ ] Appropriate automated tests included? | ||
* [ ] Code style and in-line documentation are appropriate? | ||
* [ ] Has associated issue been labelled unverified? (only applicable if this PR closes the issue) | ||
unlikelyzero marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* [ ] Has associated issue been labelled bug? (only applicable if this PR is for a bug fix) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we note that both authors and reviewers should verify this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm confused about who the intended audience is here. How does it differ from the author checklist?