Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Add @babel/eslint-parser to ignore list #5759

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

unlikelyzero
Copy link
Contributor

@unlikelyzero unlikelyzero commented Sep 14, 2022

Addresses #5760

Describe your changes:

Drive-by to reduce the frequency of #5758

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #5759 (d4859e6) into master (ffe6fd1) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head d4859e6 differs from pull request most recent head 9cd2fd1. Consider uploading reports for the commit 9cd2fd1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5759      +/-   ##
==========================================
+ Coverage   53.97%   54.00%   +0.03%     
==========================================
  Files         597      597              
  Lines       22526    22526              
  Branches     2064     2064              
==========================================
+ Hits        12159    12166       +7     
+ Misses       9788     9782       -6     
+ Partials      579      578       -1     
Flag Coverage Δ *Carryforward flag
e2e-ci 39.49% <ø> (ø) Carriedforward from cae579f
e2e-full 51.23% <ø> (ø) Carriedforward from cae579f
e2e-stable 48.75% <ø> (ø)
unit 50.34% <ø> (+0.03%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...c/plugins/persistence/couch/CouchObjectProvider.js 57.52% <0.00%> (+0.97%) ⬆️
...ettingsSynchronizer/URLTimeSettingsSynchronizer.js 97.97% <0.00%> (+1.01%) ⬆️
src/plugins/timeConductor/ConductorHistory.vue 53.53% <0.00%> (+1.01%) ⬆️
.../plugins/timeConductor/ConductorInputsRealtime.vue 51.19% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe6fd1...9cd2fd1. Read the comment docs.

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ozyx ozyx enabled auto-merge (squash) September 14, 2022 21:25
@ozyx ozyx merged commit 2a689b8 into master Sep 14, 2022
@unlikelyzero unlikelyzero deleted the ignore-patch-eslint-parser branch September 14, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants