Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] More VIPER compatibility fixes #5582

Merged
merged 23 commits into from
Jul 29, 2022
Merged

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Jul 29, 2022

Closes #5571
Contributes towards #5513

Describe your changes:

  • Allows createDomainObjectWithDefaults to create multiple domain objects in a row
  • Updates some test suites to use createDomainObjectWithDefaults
  • Generalizes references to My Items/Shared Items
  • Disables / updates docs for fixtures which are WIP and not meant to be used currently
  • Adds a new @2p annotation for tests involving multi-user interactivity
  • Updates some selectors to be more deterministic

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx requested a review from unlikelyzero July 29, 2022 23:17
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #5582 (5bf9e25) into master (22924f1) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5582      +/-   ##
==========================================
+ Coverage   53.46%   53.47%   +0.01%     
==========================================
  Files         594      594              
  Lines       21994    21994              
  Branches     2050     2050              
==========================================
+ Hits        11759    11762       +3     
+ Misses       9661     9658       -3     
  Partials      574      574              
Flag Coverage Δ *Carryforward flag
e2e-ci 39.49% <ø> (ø) Carriedforward from 22924f1
e2e-full 48.81% <ø> (ø) Carriedforward from 22924f1
e2e-stable 47.67% <ø> (+0.18%) ⬆️
unit 50.13% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../plugins/timeConductor/ConductorInputsRealtime.vue 49.39% <0.00%> (-1.21%) ⬇️
src/selection/Selection.js 76.66% <0.00%> (+1.11%) ⬆️
src/plugins/tabs/components/tabs.vue 36.00% <0.00%> (+1.60%) ⬆️
src/ui/inspector/details/Properties.vue 61.40% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22924f1...5bf9e25. Read the comment docs.

@ozyx ozyx requested a review from khalidadil July 29, 2022 23:22
@unlikelyzero unlikelyzero merged commit fc3614d into master Jul 29, 2022
@unlikelyzero unlikelyzero deleted the e2e-viper-compatibility-fixes branch July 29, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] createDomainObjectWithDefaults should be able to create multiple objects in a row
2 participants