Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots y axis and legend fixes #5062

Merged
merged 5 commits into from
Apr 19, 2022
Merged

Plots y axis and legend fixes #5062

merged 5 commits into from
Apr 19, 2022

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Apr 12, 2022

Closes #5058, #5057

Describe your changes:

Set the unit for a plot series if the yKey changes after initialization
Show y axis label if all series in the plot have the same range value.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #5062 (2705a7a) into master (21ae9f4) will increase coverage by 0.00%.
The diff coverage is 55.55%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5062   +/-   ##
=======================================
  Coverage   49.89%   49.89%           
=======================================
  Files         525      525           
  Lines       19218    19226    +8     
  Branches     1733     1734    +1     
=======================================
+ Hits         9588     9593    +5     
- Misses       9203     9206    +3     
  Partials      427      427           
Impacted Files Coverage Δ
src/plugins/plot/axis/YAxis.vue 66.66% <0.00%> (-6.07%) ⬇️
src/plugins/plot/MctPlot.vue 52.30% <66.66%> (+0.38%) ⬆️
src/plugins/plot/configuration/PlotSeries.js 67.07% <100.00%> (+0.20%) ⬆️
src/api/objects/ObjectAPI.js 91.16% <0.00%> (-2.21%) ⬇️
src/ui/router/Browse.js 86.48% <0.00%> (-1.36%) ⬇️
src/ui/inspector/details/Properties.vue 62.50% <0.00%> (+1.78%) ⬆️
src/api/composition/DefaultCompositionProvider.js 81.81% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ae9f4...2705a7a. Read the comment docs.

@shefalijoshi shefalijoshi changed the title [5058] Change the unit if the yKey changes after initialization Plots y axis and legend fixes Apr 12, 2022
@shefalijoshi shefalijoshi requested a review from jvigliotta April 12, 2022 22:53
@davetsay davetsay self-requested a review April 14, 2022 20:12
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great (and quick) work! LGTM!

@shefalijoshi shefalijoshi enabled auto-merge (squash) April 19, 2022 17:33
@shefalijoshi shefalijoshi merged commit a3c0e07 into master Apr 19, 2022
@shefalijoshi shefalijoshi deleted the plot-fixes branch April 19, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Plot] Unit column is not populating in plot legend
2 participants