Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imagery layers #4968

Merged
merged 149 commits into from
Jun 4, 2022
Merged

Imagery layers #4968

merged 149 commits into from
Jun 4, 2022

Conversation

nikhilmandlik
Copy link
Contributor

@nikhilmandlik nikhilmandlik commented Mar 22, 2022 •
edited
Loading

Closes NIRVSSOMCT-271

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

michaelrogers and others added 30 commits December 3, 2021 16:06
@michaelrogers
Add a selectable class to main-image to enable crosshair and disable …
4bb4528 
…drag
@michaelrogers
Add event helpers and draw library from plots
5ec9b91
@michaelrogers
Added zoom control button test
c4cc2f4
@michaelrogers
Exclude tests
c69374b
@michaelrogers
ARemove canvas related element and scale using background-image
6e5574d
@michaelrogers
WIP: scale translation
8b3f6b9
@michaelrogers
Remove unused draw library files
1188663
@shefalijoshi
Update version number (#4759)
457cd42
@michaelrogers
Separated the translation calculations externally
0d06308
@akhenry
Alternative implementation of zoomImage
d53ce2d
@michaelrogers
Add panning handlers
d1a899c
@michaelrogers
Change click listener to mousedown
30a7846
@michaelrogers
Pan capability
bfc7f2d
@michaelrogers
Capture initial wheelzoom coordinates by using debounced flag
a20da34
@scottbell
update copyright (#4775)
169c23d
@michaelrogers
Add debounced method to track wheel zoom sequence
fb84c05
@akhenry
Observe changes to sub-objects in flexible layouts. (#4780)
205dc67 
* Get child of flex layout as mutable if possible

* Fix bug when no default notebook defined
@shefalijoshi
Follow domain object changes for Independent time conductor (#4783)
2f292fb 
* Track if domain object changes when independent time conductor is in use.
@shefalijoshi
fix typo when using fallback template (#4784)
44f5372
@michaelrogers
Code cleanup
a5c734b
@shefalijoshi
Request data when switching between real time and fixed. (#4807)
2329076 
* Request data when switching between real time and fixed.
Also add some null checks
* Address review comments - add more conditional logic to optimize time conductor.
@shefalijoshi
Revert "Request data when switching between real time and fixed. (#4807…
2732e9f 
…)" (#4809)

This reverts commit 2329076.
@charlesh88
Styling for mct34
daaf7f0 
- Moved controls into local controls holder;
- `<a>` tags converted to `button`;
- WIP! Have not linted or made sure I didn't break tests yet;
@michaelrogers
Moved constants to a global
28da3ed
@michaelrogers
Removed draw library
c23ab66
@michaelrogers
Cleanup canvas remnants
fff822f
@michaelrogers
Revert image tag comment
9653def
@michaelrogers
Added visibile clip and corrected background-size property
8485e79
@michaelrogers
Add a selectable class to main-image to enable crosshair and disable …
b16d50e 
…drag
@michaelrogers
Add event helpers and draw library from plots
1a54d44
@shefalijoshi shefalijoshi enabled auto-merge (squash) May 23, 2022 20:41
@unlikelyzero unlikelyzero added pr:e2e Automatically triggers e2e tests to run pr:visual labels Jun 3, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Started e2e Run. Follow along: https://github.com/nasa/openmct/actions/runs/2435817410

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Started e2e Run. Follow along: https://github.com/nasa/openmct/actions/runs/2435817410

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Failure ❌ ! Build artifacts are here: https://github.com/nasa/openmct/actions/runs/2435817410

@shefalijoshi shefalijoshi merged commit 111b0d0 into master Jun 4, 2022
@shefalijoshi shefalijoshi deleted the imagery-layers branch June 4, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesh88 charlesh88 charlesh88 approved these changes

@shefalijoshi shefalijoshi shefalijoshi approved these changes

@michaelrogers michaelrogers Awaiting requested review from michaelrogers

Assignees
No one assigned
Labels
pr:e2e Automatically triggers e2e tests to run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nikhilmandlik @charlesh88 @shefalijoshi @michaelrogers @unlikelyzero @akhenry @scottbell @johnhill2 @jvigliotta