Fix display layout items getting cut off on the bottom (like plots) #4903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix Vue warnings
Codecov Report
@@ Coverage Diff @@
## release/2.0.1 #4903 +/- ##
==============================================
Coverage 50.54% 50.55%
==============================================
Files 498 498
Lines 18380 18380
Branches 1659 1659
==============================================
+ Hits 9291 9292 +1
- Misses 8670 8671 +1
+ Partials 419 417 -2
Continue to review full report at Codecov.
|
|
@shefalijoshi sync with me and we can write a visual test for this as a part of this PR |
unlikelyzero
added
pr:e2e
|
Started e2e Run. Follow along: https://github.com/nasa/openmct/actions/runs/1923929575 |
1 similar comment
|
Started e2e Run. Follow along: https://github.com/nasa/openmct/actions/runs/1923929575 |
|
Success ✅ ! Build artifacts are here: https://github.com/nasa/openmct/actions/runs/1923929575 |
|
Failure ❌ ! Build artifacts are here: https://github.com/nasa/openmct/actions/runs/1923929575 |
|
@shefalijoshi and @unlikelyzero to sync on finishing visual test |
shefalijoshi
requested review from
jvigliotta and
michaelrogers
and removed request for
davetsay and
jvigliotta
michaelrogers
previously approved these changes
Mar 15, 2022
michaelrogers
approved these changes
Mar 15, 2022
unlikelyzero
added a commit
that referenced
this pull request
Mar 23, 2022
* Correctly use creatable attribute and persistability when working with domainObjects (#4898) (#4936) * making move action location check persistability * adding persistence check instead of creatability for styles * added check for link action to make sure parent is persistable * debug * adding parent to link action and move action form location controls so they can be used in the form * adding parent persistability check for duplicate * updating multilple actions appliesTo methods to check for persistability * updated the tree to not require an initial selection if being used in a form * remove noneditable folder plugin * added persistence check for the parent, in the create wizard * minor name change * removing noneditabl folder from default plugins as well * checking the correct parent for persistability in create wizard * importing file-saver correctly * updated tests for import as json * changes addressing PR review: using consts, removing comments, removing unneccessary code Co-authored-by: Scott Bell <[email protected]> Co-authored-by: Jamie V <[email protected]> Co-authored-by: Scott Bell <[email protected]> * Fix display layout items getting cut off on the bottom (like plots) (#4903) * Fix display layout items getting cut off on the bottom (like plots) Also fix Vue warnings * Add partial e2e test for this bug fix. WIP. * Address review comments Co-authored-by: John Hill <[email protected]> * Link action fix (#4945) * handling edge case for linking a root item * added location to viper plans (couch search folder) set to ROOT, added a check to remove action for alias (so you can remove linked nonpersistable items) * added check for no parent in remove action (which means it is a root item) * updating test * Update time conductor inputs realtime (#4877) * Update time conductor inputs realtime * Update moveObjects.e2e.spec.js * Update importAsJson.e2e.spec.js * Update default.spec.js Co-authored-by: Jamie V <[email protected]> Co-authored-by: Scott Bell <[email protected]> Co-authored-by: John Hill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add display: flex to object view container to accommodate addition of independent time conductor to the views.
Closes #4902 #4901
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist