Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task automation and test improvement #4673

Merged
merged 25 commits into from
Jan 20, 2022

Conversation

unlikelyzero
Copy link
Contributor

@unlikelyzero unlikelyzero commented Jan 5, 2022

Closes: #4423

Describe your changes:

This ticket attempts to address some of the issues we've been having with missed or slipped comments or testing notes. As the team has grown, our change velocity has increased -- and so have the associated number of PRs/Issues.

In the first implementation, we will not be blocking PRs -- just informing of failure.

Note: there is currently a bug with prcop which prevents it from picking up changes to the main config file on branches vs master. That is being tracked here makaroni4/prcop#3

This will work after merge to master

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)
  • List of Acceptance Tests Performed. These will be turned into e2e tests.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #4673 (50c3f23) into master (ba2a603) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4673      +/-   ##
==========================================
- Coverage   56.44%   56.37%   -0.08%     
==========================================
  Files         718      718              
  Lines       22813    22813              
  Branches     1659     1659              
==========================================
- Hits        12876    12860      -16     
- Misses       9530     9545      +15     
- Partials      407      408       +1     
Impacted Files Coverage Δ
src/plugins/imagery/components/ImageryView.vue 36.76% <0.00%> (-3.74%) ⬇️
src/api/objects/ObjectAPI.js 89.30% <0.00%> (-2.14%) ⬇️
src/ui/components/ObjectView.vue 44.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba2a603...50c3f23. Read the comment docs.

@unlikelyzero unlikelyzero marked this pull request as ready for review January 7, 2022 19:04
@akhenry akhenry requested a review from jvigliotta January 10, 2022 22:48
Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really awesome, and adds a lot of value. Two small suggestions inline. I also want to make sure @jvigliotta takes a look at this.

@jvigliotta
Copy link
Contributor

jvigliotta commented Jan 11, 2022

@unlikelyzero Maybe not a check-box, but can we mention something to the effect of "If applicable, any outside contributors must have a signed CLA on file."?

@unlikelyzero unlikelyzero requested a review from akhenry January 18, 2022 23:36
@unlikelyzero
Copy link
Contributor Author

@jvigliotta spun that out to automation here #4739

Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the CLA comment has been addressed, this is good to merge.

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)
  • List of Acceptance Tests Performed.

@unlikelyzero unlikelyzero requested review from akhenry and removed request for akhenry January 20, 2022 17:57
@unlikelyzero unlikelyzero reopened this Jan 20, 2022
@akhenry akhenry enabled auto-merge (squash) January 20, 2022 18:30
@akhenry akhenry merged commit cf47f7c into master Jan 20, 2022
@akhenry akhenry deleted the Task-automation-and-test-improvement branch January 20, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Automate the labeling of issues (to some extent)
5 participants