-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task automation and test improvement #4673
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4673 +/- ##
==========================================
- Coverage 56.44% 56.37% -0.08%
==========================================
Files 718 718
Lines 22813 22813
Branches 1659 1659
==========================================
- Hits 12876 12860 -16
- Misses 9530 9545 +15
- Partials 407 408 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really awesome, and adds a lot of value. Two small suggestions inline. I also want to make sure @jvigliotta takes a look at this.
@unlikelyzero Maybe not a check-box, but can we mention something to the effect of "If applicable, any outside contributors must have a signed CLA on file."? |
@jvigliotta spun that out to automation here #4739 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the CLA comment has been addressed, this is good to merge.
Reviewer Checklist
- Changes appear to address issue?
- Changes appear not to be breaking changes?
- Appropriate unit tests included?
- Code style and in-line documentation are appropriate?
- Commit messages meet standards?
- Has associated issue been labelled
unverified
? (only applicable if this PR closes the issue) - Has associated issue been labelled
bug
? (only applicable if this PR is for a bug fix) - List of Acceptance Tests Performed.
Closes: #4423
Describe your changes:
This ticket attempts to address some of the issues we've been having with missed or slipped comments or testing notes. As the team has grown, our change velocity has increased -- and so have the associated number of PRs/Issues.
In the first implementation, we will not be blocking PRs -- just informing of failure.
Note: there is currently a bug with prcop which prevents it from picking up changes to the main config file on branches vs master. That is being tracked here makaroni4/prcop#3
This will work after merge to master
All Submissions:
Author Checklist
Reviewer Checklist