Move off node10 and add intellisense #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4643 +/- ##
==========================================
+ Coverage 56.37% 56.41% +0.03%
==========================================
Files 718 718
Lines 22807 22807
Branches 1658 1658
==========================================
+ Hits 12857 12866 +9
+ Misses 9539 9533 -6
+ Partials 411 408 -3
Continue to review full report at Codecov.
|
|
@unlikelyzero Tests are failing. |
|
Shefali, the tests aren't failing. It's failing to install on Node16.
…On Thu, Dec 30, 2021, 09:23 Shefali Joshi ***@***.***> wrote:
@unlikelyzero <https://github.com/unlikelyzero> Tests are failing.
—
Reply to this email directly, view it on GitHub
<#4643 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC66ZFIARL7QGJ7Z27JRMHDUTSIPLANCNFSM5K63HA6Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
unlikelyzero
commented
Jan 3, 2022
…ntial issue with Node 17 in case the config changes closer to defaults At the moment there is no error with Node 17 because the config strays from the defaults and avoids the common case. Also add a tsconfig.json file that enables VS Code and other IDEs to perform type checking on the side. For example now the webpack config file is type checked. This does not impact any existing processes, our build scripts are left untouched and only IDEs will use it for live intellisense and type checking when viewing files (f.e. showing helpful red squiggly underlines on type errors)
|
@trusktr that change still didn't take on node16. It may only apply to node17? |
True, that was only for Node 17. Trying to find out this Node 16 mystery. Gonna start toggling settings in webpack conf. |
|
@shefalijoshi when you have a chance can you look at the ts config? |
akhenry
requested changes
Jan 6, 2022
akhenry
approved these changes
Jan 7, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4584 and #4690
All Submissions:
Author Checklist