Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MCT-Template component #4537

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Remove MCT-Template component #4537

merged 2 commits into from
Dec 7, 2021

Conversation

akhenry
Copy link
Contributor

@akhenry akhenry commented Dec 7, 2021

Closes #4536

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes? N/A - just removes legacy code.
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #4537 (149dd4a) into master (6bdea20) will increase coverage by 0.48%.
The diff coverage is n/a.

❗ Current head 149dd4a differs from pull request most recent head aae3cdb. Consider uploading reports for the commit aae3cdb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4537      +/-   ##
==========================================
+ Coverage   69.36%   69.85%   +0.48%     
==========================================
  Files         994     1018      +24     
  Lines       35806    36802     +996     
  Branches     1629     1588      -41     
==========================================
+ Hits        24837    25708     +871     
- Misses      10565    10690     +125     
  Partials      404      404              
Impacted Files Coverage Δ
src/ui/layout/Layout.vue 20.00% <ø> (ø)
src/tools/url.js 69.23% <0.00%> (-30.77%) ⬇️
src/plugins/move/MoveAction.js 30.64% <0.00%> (-23.09%) ⬇️
src/ui/layout/CreateButton.vue 25.00% <0.00%> (-3.00%) ⬇️
src/ui/router/ApplicationRouter.js 85.26% <0.00%> (-1.06%) ⬇️
...c/plugins/persistence/couch/CouchObjectProvider.js 81.36% <0.00%> (-0.46%) ⬇️
src/MCT.js 95.96% <0.00%> (-0.13%) ⬇️
src/plugins/duplicate/DuplicateTask.js 97.64% <0.00%> (-0.11%) ⬇️
src/api/api.js 100.00% <0.00%> (ø)
src/plugins/plugins.js 89.70% <0.00%> (ø)
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bdea20...aae3cdb. Read the comment docs.

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I have never been able to make code coverage happy, even when removing heaps of code. Well done.

Reviewer Checklist

Changes appear to address issue? Y
Appropriate unit tests included? N/A
Code style and in-line documentation are appropriate? Y
Commit messages meet standards? Y
Has associated issue been labelled unverified? Y

@davetsay davetsay enabled auto-merge (squash) December 7, 2021 22:06
@davetsay davetsay merged commit 85fe838 into master Dec 7, 2021
@davetsay davetsay deleted the remove-mct-template branch December 13, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mct-template component
2 participants