Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Update our top level security policy #4429

Merged
merged 7 commits into from
Nov 10, 2021
Merged

[Task] Update our top level security policy #4429

merged 7 commits into from
Nov 10, 2021

Conversation

unlikelyzero
Copy link
Contributor

Closes: #4424

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #4429 (7bb99be) into master (6d4a324) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4429   +/-   ##
=======================================
  Coverage   69.76%   69.76%           
=======================================
  Files        1029     1029           
  Lines       36788    36788           
  Branches     1580     1580           
=======================================
  Hits        25664    25664           
  Misses      10729    10729           
  Partials      395      395           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4a324...7bb99be. Read the comment docs.

Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might just be missing something, but it looks to me as though the feature request template has been removed, and a new "maintenance" template has been added, and it seems like we need both?

@@ -1,23 +0,0 @@
<!--- This is for filing enhancements or features. If you have a general -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This meant to be deleted?

@unlikelyzero
Copy link
Contributor Author

unlikelyzero commented Nov 6, 2021

@akhenry sorry, i wasn't clear in the description. We have an old unused template (from our original attempt at implementing templates). Because it wasn't configured correctly, it's just unused and can be removed.

This PR adds a new maintenance type in addition to remove the improperly formatted one.

@unlikelyzero unlikelyzero requested a review from akhenry November 6, 2021 01:45
@akhenry
Copy link
Contributor

akhenry commented Nov 10, 2021

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A
  3. Code style and in-line documentation are appropriate? Y
  4. Commit messages meet standards? Y
  5. Has associated issue been labelled unverified? (only applicable if this PR closes the issue) Y

@akhenry akhenry merged commit 566469e into master Nov 10, 2021
@akhenry akhenry deleted the security-policy branch November 10, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Issue template for Security Issues and type:maintenance
2 participants