Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code cleanup] Remove legacy about dialog #4038 #4368

Merged
merged 10 commits into from
Dec 6, 2021

Conversation

depperm
Copy link
Contributor

@depperm depperm commented Oct 25, 2021

Fixes #4038

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

@akhenry akhenry requested a review from jvigliotta October 25, 2021 20:59
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #4368 (cef39f0) into master (5caa5e1) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head cef39f0 differs from pull request most recent head cbccd74. Consider uploading reports for the commit cbccd74 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4368      +/-   ##
==========================================
- Coverage   69.79%   69.75%   -0.04%     
==========================================
  Files        1029     1022       -7     
  Lines       36847    36799      -48     
  Branches     1589     1589              
==========================================
- Hits        25716    25668      -48     
+ Misses      10728    10727       -1     
- Partials      403      404       +1     
Impacted Files Coverage Δ
src/installDefaultBundles.js 100.00% <ø> (ø)
...c/plugins/persistence/couch/CouchObjectProvider.js 69.56% <0.00%> (-0.44%) ⬇️
src/plugins/imagery/components/ImageryTimeView.vue 72.88% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c9679...cbccd74. Read the comment docs.

@nikhilmandlik nikhilmandlik changed the title Mct 4038 [Code cleanup] Remove legacy about dialog #4038 Nov 29, 2021
Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @depperm, thank you!

@jvigliotta jvigliotta enabled auto-merge (squash) December 6, 2021 19:26
@jvigliotta jvigliotta merged commit 63fabe5 into nasa:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code cleanup] Remove legacy about dialog
2 participants