Condition sets only persist if actively editing #4262

shefalijoshi · 2021-09-27T21:14:14Z

Previously, the motivation to update a condition's description and save to the persistence store was that the condition description was shared by the condition set view as well as the Styles tab view (as we were trying to avoid calling object.get for telemetry endpoints in the Styles view)
Since this persistence is causing conflicts on couchDB when multiple users are using Open MCT, now we only save the summary for conditions if there is a user initiated operation.
Loading the composition of a condition set will still update the condition summaries to the condition set domain object but not save them to the persistence store. This should ensure that if telemetry endpoints go missing after a condition set is created, the summary reflects this correctly.

Resolves #4146

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this change backwards compatible? Will users need to change how they are calling the API, or how they've extended core plugins such as Tables or Plots?

Author Checklist

Changes address original issue?
Unit tests included and/or updated with changes?
Command line build passes?
Has this been smoke tested?
Testing instructions included in associated issue?

…uest.

…tively editing the condition set.

nikhilmandlik

Looks good, Small changes/questions

nikhilmandlik · 2021-09-27T21:21:38Z

src/plugins/condition/ConditionManager.js

@@ -139,10 +146,17 @@ export default class ConditionManager extends EventEmitter {
        }
    }

+    getConditionDescription(condition) {
+        condition.updateDescription();


getConditionDescription is calling updateDescription on condition, feels incorrect. May be rename something else?

Good point. I could call this updateConditionDescription.

nikhilmandlik · 2021-09-27T21:23:01Z

src/plugins/condition/ConditionManager.js

@@ -220,7 +230,7 @@ export default class ConditionManager extends EventEmitter {
            this.conditionSetDomainObject.configuration.conditionCollection.unshift(newCondition);
        }

-        this.initCondition(newCondition, index);
+        this.initCondition(newCondition, index, true);


may be can call 'init' and then 'update'?

I think there's no harm in assigning the summary all the time. I'm going to remove the 3rd parameter.

hmm, ll it trigger mutate?

no it won't

src/plugins/condition/criterion/AllTelemetryCriterion.js

nikhilmandlik

LGTM

nikhilmandlik · 2021-09-28T19:43:25Z

Reviewer Checklist

Changes appear to address issue?
Appropriate unit tests included?
Code style and in-line documentation are appropriate?
Commit messages meet standards?
Has associated issue been labelled unverified? (only applicable if this PR closes the issue)

* Notebook conflict auto retry 1.7.7 (#4230) * Use timeFormatter.parse to get the timestamp of imagery since the source could be something other than key (#4238) * If there is a pending create request for an id, queue a duplicate request. (#4243) * [Telemetry Tables] Handling Request Loading (#4245) * Fix file selection on pressing enter key (#4246) * starting loading as false, since that makes sense (#4247) * Hide independent time conductor mode if only 1 mode option is available. (#4250) * Fix bargraph color selection (#4253) * snapshot clicked while in edit mode should open in preview mode #4115 (#4257) * Fix missing object handling in several vues (#4259) * Flexible Layouts display Condition Sets as their editing/browsing interface (#4179) * Flexible Layouts display Condition Sets as their editing/browsing interface #4141 * [Telemetry Table] Progress bar tests (#4249) * Remove alert styling and hide pause button if in Fixed Time mode. (#4263) * [Table/Collection Fixes] Clearing correctly, no mutating options, no duplicate requests (#4261) * Condition sets only persist if actively editing (#4262) * Imagery views should follow time context (#4264) * Equal stacked plot y widths for all it's sub-plots (#4267) * Fix Bar Graph related CSS (#4270) * Bar graph review comment fixes (#4232) * Mct4196 - Fixes Conditional Styling not being applied when editing a Condition Widget (#4255) * Fix plot zoom when child of time strip (#4272) * Resume plot if no pan, zoom, or drag action is taken (#4138) (#4256) * [Telemetry Collection] No duplicate requests on load (#4274) * doing the easy thing first (#4278) * Bargraph time metadata should consider 'source' (#4289) * Show clicked image in large view (#4280) * added icon for inspector (#4275) * Bar graph style nullcheck (#4291) * Stacked plots need to align the Y axis (#4286) * Duplicate Request Fixes (#4295) * Add braintree sanitize url lib and sanitize form urls (#4296) * Mct4177 fix for telemetry endpoints with '.' in the key (#4308) * Remove additional request to load plots when mounted. (#4314) * Fix plots dup requests (#4324) * Merging 1.7.8 into master. Co-authored-by: Andrew Henry <[email protected]> Co-authored-by: Jamie V <[email protected]> Co-authored-by: Nikhil <[email protected]> Co-authored-by: Khalid Adil <[email protected]> Co-authored-by: Charles Hacskaylo <[email protected]> Co-authored-by: Scott Bell <[email protected]> Co-authored-by: Michael Rogers <[email protected]>

shefalijoshi added 6 commits September 21, 2021 15:16

If there is a pending create request for an id, queue a duplicate req…

cc1a5ef

…uest.

Merge branch '1.7.8' of https://github.com/nasa/openmct into 1.7.8

da1fa0b

Merge branch '1.7.8' of https://github.com/nasa/openmct into 1.7.8

a6e8f76

Merge branch '1.7.8' of https://github.com/nasa/openmct into 1.7.8

4a7ff3f

Merge branch '1.7.8' of https://github.com/nasa/openmct into 1.7.8

135edab

Don't save condition description to persistence store if we're not ac…

c69a6b0

…tively editing the condition set.

shefalijoshi requested a review from nikhilmandlik September 27, 2021 21:17

nikhilmandlik reviewed Sep 27, 2021

View reviewed changes

Rename function and remove unnecessary if condition

09c384a

shefalijoshi requested a review from nikhilmandlik September 27, 2021 21:51

nikhilmandlik approved these changes Sep 28, 2021

View reviewed changes

nikhilmandlik merged commit 476128c into 1.7.8 Sep 28, 2021

nikhilmandlik deleted the fix-conditionset-persistence branch September 28, 2021 19:43

nikhilmandlik linked an issue Sep 28, 2021 that may be closed by this pull request

Persistence errors in Condition Sets when editing Condition Widgets #4146

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Condition sets only persist if actively editing #4262

Condition sets only persist if actively editing #4262

shefalijoshi commented Sep 27, 2021 •

edited

Loading

nikhilmandlik left a comment

nikhilmandlik Sep 27, 2021

shefalijoshi Sep 27, 2021

nikhilmandlik Sep 27, 2021

shefalijoshi Sep 27, 2021

nikhilmandlik Sep 27, 2021

shefalijoshi Sep 28, 2021

nikhilmandlik left a comment

nikhilmandlik commented Sep 28, 2021 •

edited

Loading

Condition sets only persist if actively editing #4262

Condition sets only persist if actively editing #4262

Conversation

shefalijoshi commented Sep 27, 2021 • edited Loading

All Submissions:

Author Checklist

nikhilmandlik left a comment

Choose a reason for hiding this comment

nikhilmandlik Sep 27, 2021

Choose a reason for hiding this comment

shefalijoshi Sep 27, 2021

Choose a reason for hiding this comment

nikhilmandlik Sep 27, 2021

Choose a reason for hiding this comment

shefalijoshi Sep 27, 2021

Choose a reason for hiding this comment

nikhilmandlik Sep 27, 2021

Choose a reason for hiding this comment

shefalijoshi Sep 28, 2021

Choose a reason for hiding this comment

nikhilmandlik left a comment

Choose a reason for hiding this comment

nikhilmandlik commented Sep 28, 2021 • edited Loading

Reviewer Checklist

shefalijoshi commented Sep 27, 2021 •

edited

Loading

nikhilmandlik commented Sep 28, 2021 •

edited

Loading