Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mct4065 #4157

Merged
merged 22 commits into from
Sep 10, 2021
Merged

Mct4065 #4157

merged 22 commits into from
Sep 10, 2021

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Aug 27, 2021 •
edited by nikhilmandlik
Loading

fixes #4065 (comment)

All Submissions:

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

scottbell added 17 commits August 16, 2021 15:29
@scottbell
navigate to item selected for context view first, then emit action
2a0af59
@scottbell
Revert "navigate to item selected for context view first, then emit a…
da2bad6 
…ction"

This reverts commit 2a0af59.
@scottbell
forbid clear data on non-selected domain object
db20ec5
@scottbell
allow display of clear data in compositions
507284d
@scottbell
Merge remote-tracking branch 'origin/master' into mct4065
51faa3d
@scottbell
only clear plots with associated domain object from clear
06f6491
@scottbell
get keys in the openmct way
b4edea0
@scottbell
cleared up comments
4428b37
@scottbell
uses selection path instead and works with empty domain objects
36fcfce
@scottbell
stuck trying to figure out how to get parents/children
229c800
@scottbell
works on stacked plots and layouts now. need to check that overlays w…
0eee901 
…ork now
@scottbell
now works for overlay plots too
2f66221
@scottbell
added some handy comments
2283575
@scottbell
worked for stacked plots inside of layouts now too
705fbe4
@scottbell
Merge remote-tracking branch 'origin/master' into mct4065
f021d45
@scottbell
refactored to match uppercase class names convention
157fdda
@scottbell
added some tests for clear data and did some minor linting
0e91996
@scottbell
Copy link
Contributor Author

To test:
#4065 (comment)

nikhilmandlik
nikhilmandlik suggested changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@nikhilmandlik nikhilmandlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, couple of small corrections and changes for better readability 😃

nikhilmandlik
nikhilmandlik approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@nikhilmandlik nikhilmandlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikhilmandlik nikhilmandlik merged commit 2131ef2 into master Sep 10, 2021
@nikhilmandlik nikhilmandlik deleted the mct4065 branch September 10, 2021 18:31
@nikhilmandlik
Copy link
Contributor

Reviewer Checklist

Check Passed
Changes appear to address issue? Y
Appropriate unit tests included? Y
Code style and in-line documentation are appropriate? Y
Commit messages meet standards? Y
Has associated issue been labelled unverified? (only applicable if this PR closes the issue) Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilmandlik nikhilmandlik nikhilmandlik approved these changes

@shefalijoshi shefalijoshi Awaiting requested review from shefalijoshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear data for objects clears data for all objects
2 participants
@scottbell @nikhilmandlik