Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old timeline bundle and template. remove it from Legacy bundles. #4048

Merged
merged 2 commits into from
Jul 23, 2021
Merged

remove old timeline bundle and template. remove it from Legacy bundles. #4048

merged 2 commits into from
Jul 23, 2021

Conversation

kobe1104
Copy link
Contributor

@kobe1104 kobe1104 commented Jul 21, 2021 •
edited
Loading

Referred issue: #4028

All Submissions:

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue? (Check original issue)

@davetsay davetsay enabled auto-merge (squash) July 23, 2021 20:50
davetsay
davetsay approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewer Checklist
Changes appear to address issue? Y
Appropriate unit tests included? N/A
Code style and in-line documentation are appropriate? Y
Commit messages meet standards? Y
Has associated issue been labelled unverified? Y

@davetsay davetsay merged commit f8f2e7d into master Jul 23, 2021
@davetsay davetsay deleted the remove-timeline branch July 23, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davetsay davetsay davetsay approved these changes

@akhenry akhenry Awaiting requested review from akhenry

@shefalijoshi shefalijoshi Awaiting requested review from shefalijoshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobe1104 @davetsay