Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description for condition set only when necessary, saving persistence calls to CouchDB. #4030

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Update description for condition set only when necessary, saving persistence calls to CouchDB. #4030

merged 1 commit into from
Jul 16, 2021

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Jul 15, 2021 •
edited
Loading

Resolves #3954

All Submissions:

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

@shefalijoshi shefalijoshi changed the base branch from master to 1.7.5 July 15, 2021 22:36
@shefalijoshi shefalijoshi requested a review from davetsay July 16, 2021 16:11
@jvigliotta jvigliotta self-requested a review July 16, 2021 16:46
jvigliotta
jvigliotta approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jvigliotta jvigliotta merged commit 51d4ad5 into 1.7.5 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvigliotta jvigliotta jvigliotta approved these changes

@nikhilmandlik nikhilmandlik Awaiting requested review from nikhilmandlik

@davetsay davetsay Awaiting requested review from davetsay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Persistence errors when using Conditional Styling
2 participants
@shefalijoshi @jvigliotta