Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind method to 'this' so that its listeners are correctly unbound on destroy #3948

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Bind method to 'this' so that its listeners are correctly unbound on destroy #3948

merged 4 commits into from
Jun 21, 2021

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Jun 15, 2021 •
edited
Loading

Resolves #3943
The issue here was not a problem with Plan views. It was a side effect of the style rule manager listeners not being removed when destroyed.

All Submissions:

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

@shefalijoshi shefalijoshi changed the title Bind method to 'this' so that its listener can work correctly Bind method to 'this' so that its listeners are correctly unbound on destroy Jun 15, 2021
@shefalijoshi shefalijoshi requested review from jvigliotta and removed request for akhenry June 17, 2021 20:38
jvigliotta
jvigliotta approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great to me. Nice work @shefalijoshi !

@jvigliotta jvigliotta merged commit fa5aceb into master Jun 21, 2021
@jvigliotta jvigliotta deleted the fix-styleRules branch June 21, 2021 17:45
@akhenry akhenry mentioned this pull request Jun 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvigliotta jvigliotta jvigliotta approved these changes

@charlesh88 charlesh88 Awaiting requested review from charlesh88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plan View/Timestrip not responding to Time Conductor bounds changes
2 participants
@shefalijoshi @jvigliotta