"Import as JSON" dialog is not intuitive #3761 #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed select file button; - Fixed required asterisk color in hint text; - Updated markup and refined CSS selector;
|
@nikhilmandlik I've done a bit of sanding and fixed the styling for the Select File button and asterisk in the hint text. Over to you. |
shefalijoshi
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Reviewer Checklist
- Changes appear to address issue? Y
- Appropriate unit tests included? N
- Code style and in-line documentation are appropriate? Y
- Commit messages meet standards? Y
- Has associated issue been labelled
unverified? (only applicable if this PR closes the issue) Y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
resolves: #3761
Author Checklist: