[Time Conductor] Persist Time Conductor state in URL #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reassigning back to me, found an issue with deltas loaded from URL not being reflected in UI. |
…tor bounds in URL. Fixes #1231
Fixing tests Fixed broken tests Added tests Fixed style errors
|
@akhenry After squash-merging #1287 I went ahead and rebased this branch onto master and resolved some small conflicts. Hope that's helpful for you, but it does mean you'll have to wipe out your local branch and checkout a new copy from origin. If this is a pain in the butt, feel free to force-push your local version of open1231. I also archived the old version of the branch as open1231-pre-rebase just in case. |
|
I take it back, this totally works, deltas and all. CONFUSION INTENSIFIES Over to you @VWoeltjen |
Reviewer Checklist
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently large delta with master due to it being based on open1193 / #1287 which has not been merged yet. Should either change base to open1193 for review, or wait until #1287 is merged.
Author Checklist