[Edit] Switch other edit actions to mct-control

[ghost]

Went back to the edit menu cause it felt like I left the prev issue unfinished. Fixes #1198

There's a bit of a logic change. This here:

ng-class="{ major: $index === 0 && saveActions.length === 0 }"

Was not kept. Used to be major: $index === 0 before the save button dropdown changes, but back then there was no separation between save actions and other actions, so I'm almost certain that it was just so that the save button shows up as major.

Now that the save buttons show up as major anyway and are first in the menu, this doesn't seem to be useful anymore. It can only be useful if we have an edit context where we don't allow the user to save changes (no save actions available), which is something that doesn't make much sense (unless we add something like auto-saved objects?).

It can be brought back pretty easily if needed, via cssclass: currentAction.getMetadata().cssclass + ($index === 0 && saveActions.length === 0 ? ' major' : '') but if it's a condition that will/should never pass in practice, I'd rather we just removed it entirely.

Thoughts?

Author Checklist

Changes address original issue? - Y
Unit tests included and/or updated with changes? - N/A, it's a markup change
Command line build passes? - Y
Changes have been smoke-tested? - Y

[VWoeltjen]

I'd do this as currentAction.perform.bind(currentAction) so that the action being invoked has an appropriate this. I would expect this to work currently because LoggingActionDecorator reassigns perform on actions at the instance level, but if that is ever refactored/removed it could cause problems here.

[ghost]

Good catch, also updated the original mct-button. I had to go with a bit of indirection to do it because Angular seems to dislike seeing calls to bind, apply & co. in expressions.

[VWoeltjen]

Reviewer Checklist

1. Changes appear to address issue? Y
2. Appropriate unit tests included? N/A (change is markup only)
3. Code style and in-line documentation are appropriate? Y
4. Commit messages meet standards? Y

Thanks!