Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Update to es6-promise 3.3.0 #1190

Merged
merged 1 commit into from
Sep 13, 2016
Merged

[Build] Update to es6-promise 3.3.0 #1190

merged 1 commit into from
Sep 13, 2016

Conversation

VWoeltjen
Copy link
Contributor

...including changes to filename associated with that version.

Fixes #1183

Author Checklist

  1. Changes address original issue? Y
  2. Unit tests included and/or updated with changes? N/A (changes to build only)
  3. Command line build passes? Y
  4. Changes have been smoke-tested? Y

...including changes to filename associated with that version.

Fixes #1183
@VWoeltjen VWoeltjen added this to the Pratchett milestone Sep 13, 2016
@VWoeltjen
Copy link
Contributor Author

VWoeltjen commented Sep 13, 2016

Another option would be to remove the Promise polyfill entirely. PhantomJS 2.1.1 no longer needs it, nor should any evergreen browser.

(Edit: WIP to verify that this would work on branch drop-promise-1183)

@larkin
Copy link
Contributor

larkin commented Sep 13, 2016

@VWoeltjen IE11 doesn't have promise, so we have to keep this around for now. Going to integrate this branch.

@larkin
Copy link
Contributor

larkin commented Sep 13, 2016

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A (build only)
  3. Code style and in-line documentation are appropriate? Y
  4. Commit messages meet standards? Y

@larkin larkin merged commit f732387 into master Sep 13, 2016
@larkin larkin deleted the build-promise-1183 branch September 13, 2016 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants