Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Context Menu] New Tab button available in edit mode. #843 #1157

Merged
merged 1 commit into from
Sep 12, 2016
Merged

[Context Menu] New Tab button available in edit mode. #843 #1157

merged 1 commit into from
Sep 12, 2016

Conversation

TypicalFooBar
Copy link
Contributor

@TypicalFooBar TypicalFooBar commented Aug 29, 2016

Removed window from the editModeBlackList.

This allows the New Tab button to be used while in edit mode.

Author Checklist

  1. Changes address original issue?
    • Yes
  2. Unit tests included and/or updated with changes?
    • No
  3. Command line build passes?
    • Yes
  4. Changes have been smoke-tested?
    • Yes

@VWoeltjen VWoeltjen modified the milestones: orwl, Orwell Aug 29, 2016
@VWoeltjen
Copy link
Contributor

Thanks for the contribution, looks good to me! @akhenry - any unintended consequences of changing this blacklist that I might be missing?

@VWoeltjen VWoeltjen modified the milestones: Pratchett, Orwell Aug 30, 2016
@akhenry
Copy link
Contributor

akhenry commented Sep 5, 2016

@VWoeltjen I think this should be ok. There is #399, but it should be resolved, based on the notes on that issue. Hopefully we can close out both issues with this PR.

@TypicalFooBar Are you seeing the behavior described in #399, or does it appear to be working ok ?

@TypicalFooBar
Copy link
Contributor Author

@akhenry - I'll check this evening and let you know what I find.

@TypicalFooBar
Copy link
Contributor Author

I have not had time to check issue #399 and I wont be back home until late next week - there was a bunch of conversation on issue #843 that may be helpful, though.

@akhenry
Copy link
Contributor

akhenry commented Sep 12, 2016

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A - no code changes
  3. Code style and in-line documentation are appropriate? N/A
  4. Commit messages meet standards? Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants