Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .swp to git ignore #1150

Merged
merged 1 commit into from
Sep 5, 2016
Merged

Add .swp to git ignore #1150

merged 1 commit into from
Sep 5, 2016

Conversation

aterribili
Copy link
Contributor

@aterribili aterribili commented Aug 28, 2016

I was testing this repo, and when a opened a file using my favorite editor (vim) I saw that you forgot (or don't need) to put swp files into the .gitignore.

Author Checklist

Changes address original issue? - N/A
Unit tests included and/or updated with changes? - N/A, it's a adding type of file to .gitignore
Command line build passes? - N/A
Changes have been smoke-tested? - N/A

@dongdongwang22
Copy link

hello

@akhenry
Copy link
Contributor

akhenry commented Aug 29, 2016

@aterribili Thanks. It's not in there because none of the dev team use it as their main editor, although I do use it occasionally. It's sufficiently popular that it makes sense to include it in gitignore if it makes developers lives a little easier.

If you haven't already, please take a glance at the "Contributing" page on our site - https://nasa.github.io/openmct/contributing/ you'll find a link there to our Contributor License Agreement, which needs to be completed before we can merge anything. Once we have that, I'll merge this PR.

Thanks for your contribution!

@akhenry akhenry self-assigned this Aug 29, 2016
@aterribili
Copy link
Contributor Author

Ok, I'll do it later. Thanks! 😃

@aterribili
Copy link
Contributor Author

Email sent :)

@aterribili
Copy link
Contributor Author

I need to do something more?

@akhenry
Copy link
Contributor

akhenry commented Sep 5, 2016

Nope, nothing more to do. Thanks for your help!

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A no code changes
  3. Code style and in-line documentation are appropriate? N/A No code changes
  4. Commit messages meet standards? Y

@akhenry akhenry merged commit 58391de into nasa:master Sep 5, 2016
@aterribili aterribili deleted the patch-1 branch November 18, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants