Merge open933-1112 > open933 #1113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #993 In-progress; class renaming continued, cleanups in markup file, in-page styles ported to scss
Fixes #993 In-progress; Create menu refactoring and new mini Create menu
Fixes #993 In-progress; mode menu names and descriptors modified, markup cleaned up
Fixes #933 Resolve conflicts in mode-menu.html, mode-selector.html, time-conductor.html; apply tweaks, language, etc.
Fixes #933 Tweaks to language
Fixes #933 Tweaks to language; tweak to class name in markup
Fixes #933 Conflicts: platform/features/conductor-v2/src/TimeConductorController.js
Fixes #933 Renamed main class; removed unused <style> defs
Fixes #933 Color adjusts, mini super-menu size and font tweaks, glyphs added to selector, SVG style fixes in progress
Fixes #933 In-progress; fixed SVG text color
Fixes #933 In-progress: fixed SVG text color, field styling for fixed vs. real-time, markup cleanup
Fixes #933 In-progress: color tweaks, bar sizing, field widths
Fixes #933 In-progress: restructured markup to move modeModel farther out; animated icon
Fixes #933 Fair amount of manual fixing in time-conductor.html
Fixes #933 Fair amount of manual fixing in time-conductor.html
Fixes #933 In-progress: color/size tweaks, fixes for espresso theme
Fixes #1112 Moved min-width and overflow: hidden to TC-specific elements; removed overflow: hidden from .primary-pane
|
@charlesh88 Gotcha, I've merged this to open933. Closing this PR. |
|
For #1112 - just pushed new fix, please integrate. |
Fixes #1112 Put overflow: hidden back at outer wrapper level (now on .t-object.primary-pane ) which doens't clip the Inspector expand/collapse; did better unit testing;
|
Merged into open933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akhenry Just pushed a fix for this issue, was a pretty trivial move of some CSS.