Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify synchronization of selection in tree with state passed-in, letting Angular deal with more of the specifics. Fixes #1008.
It's a little unclear why this was failing to begin with; the
$watch
on$parent
wasn't firing when I'd expect it to. That said, the reason for doing this was essentially to replicate functionality already provided by Angular for synchronizing changes between an isolate scope and its parent. I'm comfortable with say "whatever was going on here, the Angular team has encountered and solved" instead of investing further time developing our own understanding.There's a modest cost to this change, insofar as it introduces more watches (per tree, not per node). Think this cost is incidental.
This does not address any of the UX changes proposed for #1008; just fixes the originally reported bug as it currently manifests.
Author Checklist